[Midnightbsd-cvs] src [6599] trunk/contrib/bind98/bin/named/query.c: fix a security issue in bind

[laffer1 at midnightbsd.org]

Revision: 6599
          http://svnweb.midnightbsd.org/src/?rev=6599
Author:   laffer1
Date:     2014-01-14 19:43:39 -0500 (Tue, 14 Jan 2014)
Log Message:
-----------
fix a security issue in bind

Modified Paths:
--------------
    trunk/contrib/bind98/bin/named/query.c

Modified: trunk/contrib/bind98/bin/named/query.c
===================================================================
--- trunk/contrib/bind98/bin/named/query.c	2014-01-15 00:41:44 UTC (rev 6598)
+++ trunk/contrib/bind98/bin/named/query.c	2014-01-15 00:43:39 UTC (rev 6599)
@@ -5178,8 +5178,7 @@
 	dns_fixedname_t fixed;
 	dns_hash_t hash;
 	dns_name_t name;
-	int order;
-	unsigned int count;
+	unsigned int skip = 0, labels;
 	dns_rdata_nsec3_t nsec3;
 	dns_rdata_t rdata = DNS_RDATA_INIT;
 	isc_boolean_t optout;
@@ -5192,6 +5191,7 @@
 
 	dns_name_init(&name, NULL);
 	dns_name_clone(qname, &name);
+	labels = dns_name_countlabels(&name);
 
 	/*
 	 * Map unknown algorithm to known value.
@@ -5223,13 +5223,14 @@
 		dns_rdata_reset(&rdata);
 		optout = ISC_TF((nsec3.flags & DNS_NSEC3FLAG_OPTOUT) != 0);
 		if (found != NULL && optout &&
-		    dns_name_fullcompare(&name, dns_db_origin(db), &order,
-					 &count) == dns_namereln_subdomain) {
+		    dns_name_issubdomain(&name, dns_db_origin(db)))
+		{
 			dns_rdataset_disassociate(rdataset);
 			if (dns_rdataset_isassociated(sigrdataset))
 				dns_rdataset_disassociate(sigrdataset);
-			count = dns_name_countlabels(&name) - 1;
-			dns_name_getlabelsequence(&name, 1, count, &name);
+			skip++;
+			dns_name_getlabelsequence(qname, skip, labels - skip,
+						  &name);
 			ns_client_log(client, DNS_LOGCATEGORY_DNSSEC,
 				      NS_LOGMODULE_QUERY, ISC_LOG_DEBUG(3),
 				      "looking for closest provable encloser");
@@ -5247,7 +5248,11 @@
 		ns_client_log(client, DNS_LOGCATEGORY_DNSSEC,
 			      NS_LOGMODULE_QUERY, ISC_LOG_WARNING,
 			      "expected covering NSEC3, got an exact match");
-	if (found != NULL)
+	if (found == qname) {
+		if (skip != 0U)
+			dns_name_getlabelsequence(qname, skip, labels - skip,
+						  found);
+	} else if (found != NULL)
 		dns_name_copy(&name, found, NULL);
 	return;
 }