[Midnightbsd-cvs] src [7682] trunk/lib/libmport/plist.c: fix a memory leak

laffer1 at midnightbsd.org laffer1 at midnightbsd.org
Sun Aug 7 11:59:19 EDT 2016


Revision: 7682
          http://svnweb.midnightbsd.org/src/?rev=7682
Author:   laffer1
Date:     2016-08-07 11:59:19 -0400 (Sun, 07 Aug 2016)
Log Message:
-----------
fix a memory leak

Modified Paths:
--------------
    trunk/lib/libmport/plist.c

Modified: trunk/lib/libmport/plist.c
===================================================================
--- trunk/lib/libmport/plist.c	2016-08-07 07:30:02 UTC (rev 7681)
+++ trunk/lib/libmport/plist.c	2016-08-07 15:59:19 UTC (rev 7682)
@@ -65,6 +65,11 @@
         n = STAILQ_FIRST(list);
         STAILQ_REMOVE_HEAD(list, next);
         free(n->data);
+		free(n->checksum);
+		free(n->owner);
+		free(n->group);
+		free(n->mode);
+		/* type is not a pointer */
         free(n);
     }
 
@@ -116,7 +121,8 @@
             if (cmnd == NULL)
                 RETURN_ERROR(MPORT_ERR_FATAL, "Malformed plist file.");
 
-		entry->type = parse_command(cmnd);
+			entry->checksum = NULL; /* checksum is only used by bundle read install */
+			entry->type = parse_command(cmnd);
 		if (entry->type == ASSET_FILE_OWNER_MODE)
 			parse_file_owner_mode(&entry, cmnd);
 		if (entry->type == ASSET_DIR_OWNER_MODE) {



More information about the Midnightbsd-cvs mailing list