[Midnightbsd-cvs] src [8159] trunk/sys/kern/kern_environment.c: handle null terminating character.

laffer1 at midnightbsd.org laffer1 at midnightbsd.org
Fri Sep 16 22:13:14 EDT 2016


Revision: 8159
          http://svnweb.midnightbsd.org/src/?rev=8159
Author:   laffer1
Date:     2016-09-16 22:13:14 -0400 (Fri, 16 Sep 2016)
Log Message:
-----------
handle null terminating character.

Modified Paths:
--------------
    trunk/sys/kern/kern_environment.c

Modified: trunk/sys/kern/kern_environment.c
===================================================================
--- trunk/sys/kern/kern_environment.c	2016-09-17 02:10:29 UTC (rev 8158)
+++ trunk/sys/kern/kern_environment.c	2016-09-17 02:13:14 UTC (rev 8159)
@@ -143,9 +143,9 @@
 		break;
 	}
 
-	name = malloc(KENV_MNAMELEN, M_TEMP, M_WAITOK);
+	name = malloc(KENV_MNAMELEN + 1, M_TEMP, M_WAITOK);
 
-	error = copyinstr(uap->name, name, KENV_MNAMELEN, NULL);
+	error = copyinstr(uap->name, name, KENV_MNAMELEN + 1, NULL);
 	if (error)
 		goto done;
 
@@ -176,8 +176,8 @@
 			error = EINVAL;
 			goto done;
 		}
-		if (len > KENV_MVALLEN)
-			len = KENV_MVALLEN;
+		if (len > KENV_MVALLEN + 1)
+			len = KENV_MVALLEN + 1;
 		value = malloc(len, M_TEMP, M_WAITOK);
 		error = copyinstr(uap->value, value, len, NULL);
 		if (error) {
@@ -389,10 +389,10 @@
 	KENV_CHECK;
 
 	namelen = strlen(name) + 1;
-	if (namelen > KENV_MNAMELEN)
+	if (namelen > KENV_MNAMELEN + 1)
 		return (-1);
 	vallen = strlen(value) + 1;
-	if (vallen > KENV_MVALLEN)
+	if (vallen > KENV_MVALLEN + 1)
 		return (-1);
 	buf = malloc(namelen + vallen, M_KENV, M_WAITOK);
 	sprintf(buf, "%s=%s", name, value);



More information about the Midnightbsd-cvs mailing list