[Midnightbsd-cvs] src [9349] trunk/sbin/devd/devd.h: According to devctl(4), clients must read events whole; they may not piece them

laffer1 at midnightbsd.org laffer1 at midnightbsd.org
Sat Mar 4 11:52:35 EST 2017


Revision: 9349
          http://svnweb.midnightbsd.org/src/?rev=9349
Author:   laffer1
Date:     2017-03-04 11:52:34 -0500 (Sat, 04 Mar 2017)
Log Message:
-----------
According to devctl(4), clients must read events whole; they may not piece them
together from multiple reads().  It's as if /dev/devctl is a datagram device
instead of a stream device.  However, devd's internal buffer was too small
(1025 bytes) to read an entire ereport.fs.zfs.checksum event (variable, up to
~1300 bytes).  This commit enlarges the buffer to 8k.

Modified Paths:
--------------
    trunk/sbin/devd/devd.h

Modified: trunk/sbin/devd/devd.h
===================================================================
--- trunk/sbin/devd/devd.h	2017-03-04 16:51:12 UTC (rev 9348)
+++ trunk/sbin/devd/devd.h	2017-03-04 16:52:34 UTC (rev 9349)
@@ -53,6 +53,6 @@
 __END_DECLS
 
 #define PATH_DEVCTL	"/dev/devctl"
-#define DEVCTL_MAXBUF	1025
+#define DEVCTL_MAXBUF	8192
 
 #endif /* DEVD_H */



More information about the Midnightbsd-cvs mailing list