[Midnightbsd-cvs] src [10489] trunk/lib/libutil/uucplock.c: use O_CLOEXEC

laffer1 at midnightbsd.org laffer1 at midnightbsd.org
Wed Jun 6 21:28:41 EDT 2018


Revision: 10489
          http://svnweb.midnightbsd.org/src/?rev=10489
Author:   laffer1
Date:     2018-06-06 21:28:40 -0400 (Wed, 06 Jun 2018)
Log Message:
-----------
use O_CLOEXEC

Modified Paths:
--------------
    trunk/lib/libutil/uucplock.c

Modified: trunk/lib/libutil/uucplock.c
===================================================================
--- trunk/lib/libutil/uucplock.c	2018-06-07 01:11:40 UTC (rev 10488)
+++ trunk/lib/libutil/uucplock.c	2018-06-07 01:28:40 UTC (rev 10489)
@@ -76,7 +76,8 @@
 			pid);
 	(void)snprintf(lckname, sizeof(lckname), _PATH_UUCPLOCK LOCKFMT,
 			tty_name);
-	if ((tmpfd = creat(lcktmpname, 0664)) < 0)
+	if ((tmpfd = open(lcktmpname, O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
+	    0664)) < 0)
 		GORET(0, UU_LOCK_CREAT_ERR);
 
 	for (i = 0; i < MAXTRIES; i++) {
@@ -88,7 +89,7 @@
 			 * check to see if the process holding the lock
 			 * still exists
 			 */
-			if ((fd = open(lckname, O_RDONLY)) < 0)
+			if ((fd = open(lckname, O_RDONLY | O_CLOEXEC)) < 0)
 				GORET(1, UU_LOCK_OPEN_ERR);
 
 			if ((pid_old = get_pid (fd, &err)) == -1)
@@ -132,7 +133,7 @@
 
 	snprintf(lckname, sizeof(lckname), _PATH_UUCPLOCK LOCKFMT, tty_name);
 
-	if ((fd = open(lckname, O_RDWR)) < 0)
+	if ((fd = open(lckname, O_RDWR | O_CLOEXEC)) < 0)
 		return UU_LOCK_OWNER_ERR;
 	if (get_pid(fd, &err) != getpid())
 		err = UU_LOCK_OWNER_ERR;



More information about the Midnightbsd-cvs mailing list