[Midnightbsd-cvs] [MidnightBSD/src] 9ed91c: psm: release resources on attach failure

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/src
  Commit: 9ed91c033a8fcccb8fa3d5c5635cbfd5495a7ce6
      https://github.com/MidnightBSD/src/commit/9ed91c033a8fcccb8fa3d5c5635cbfd5495a7ce6
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2020-11-14 (Sat, 14 Nov 2020)

  Changed paths:
    M sys/dev/atkbdc/psm.c

  Log Message:
  -----------
  psm: release resources on attach failure

In exactly 1/3 cases we'll release resources on failure; touch up the other
two to do so as well.

psm: use make_dev_s instead of make_dev

This most importantly reduces duplication, but it also removes any potential
race with usage of dev->si_drv1 since it's now set prior to the device being
constructed enough to be accessible.