[Midnightbsd-cvs] [MidnightBSD/src] 3583d4: MFZoL: Relax restriction on zfs_ioc_next_obj() ite...

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/src
  Commit: 3583d49105762ad4030433b81f03212be9c1544f
      https://github.com/MidnightBSD/src/commit/3583d49105762ad4030433b81f03212be9c1544f
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c

  Log Message:
  -----------
  MFZoL: Relax restriction on zfs_ioc_next_obj() iteration

Per the documentation for dnode_next_offset in dnode.c, the "txg"
parameter specifies a lower bound on which transaction the dnode can
be found in. We are interested in all dnodes that are removed between
the first and last transaction in the snapshot. It doesn't need to be
created in that snapshot to correspond to a removed file.

In fact, the behavior of zfs diff in the test case exactly matches
this: the transaction that created the data that was deleted in snapshot
"2" was produced before, in snapshot "1", definitely predating the first
transaction in snapshot "2".