[Midnightbsd-cvs] [MidnightBSD/src] b8084f: ping reads raw IP packets from the network to proc...

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/src
  Commit: b8084ffeccac92bd02461611a4c577eec918a3aa
      https://github.com/MidnightBSD/src/commit/b8084ffeccac92bd02461611a4c577eec918a3aa
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2022-11-29 (Tue, 29 Nov 2022)

  Changed paths:
    M sbin/ping/ping.c

  Log Message:
  -----------
  ping reads raw IP packets from the network to process responses in the
pr_pack() function.  As part of processing a response ping has to
reconstruct the IP header, the ICMP header and if present a "quoted
packet," which represents the packet that generated an ICMP error.  The
quoted packet again has an IP header and an ICMP header.

The pr_pack() copies received IP and ICMP headers into stack buffers
for further processing.  In so doing, it fails to take into account the
possible presence of IP option headers following the IP header in
either the response or the quoted packet.  When IP options are present,
pr_pack() overflows the destination buffer by up to 40 bytes.

Obtained from: FreeBSD