From noreply at github.com Fri Aug 18 11:27:45 2023 From: noreply at github.com (Lucas Holt) Date: Fri, 18 Aug 2023 08:27:45 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] afb58b: Remove some outdated directories from mtree Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: afb58b9bedd3d1be990a8378dc2fcdf14eaa7632 https://github.com/MidnightBSD/src/commit/afb58b9bedd3d1be990a8378dc2fcdf14eaa7632 Author: Lucas Holt Date: 2023-08-18 (Fri, 18 Aug 2023) Changed paths: M etc/mtree/BSD.usr.dist R share/man/man4/ahb.4 R share/man/man4/cm.4 R share/man/man4/digi.4 R share/man/man4/en.4 R share/man/man4/fatm.4 R share/man/man4/fpa.4 R share/man/man4/hatm.4 R share/man/man4/igb.4 R share/man/man4/ixgb.4 R share/man/man4/ixlv.4 R share/man/man4/jedec_ts.4 R share/man/man4/lmc.4 R share/man/man4/mcd.4 R share/man/man4/natm.4 R share/man/man4/natmip.4 R share/man/man4/ng_atm.4 R share/man/man4/nxge.4 R share/man/man4/patm.4 R share/man/man4/scd.4 R share/man/man4/si.4 R share/man/man4/spic.4 R share/man/man4/urtwn.4 R share/man/man4/urtwnfw.4 R share/man/man4/utopia.4 R share/man/man4/vxge.4 R share/man/man7/adding_user.7 M share/man/man9/atomic.9 R share/man/man9/boot.9 R share/man/man9/mbpool.9 R share/man/man9/utopia.9 R share/man/man9/vm_page_cache.9 Log Message: ----------- Remove some outdated directories from mtree Remove some old man pages found during test. From noreply at github.com Fri Aug 18 11:28:07 2023 From: noreply at github.com (Lucas Holt) Date: Fri, 18 Aug 2023 08:28:07 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] 8b4598: Remove some outdated directories from mtree Message-ID: Branch: refs/heads/master Home: https://github.com/MidnightBSD/src Commit: 8b4598f5237945355f1964a555fd6df16997991a https://github.com/MidnightBSD/src/commit/8b4598f5237945355f1964a555fd6df16997991a Author: Lucas Holt Date: 2023-08-18 (Fri, 18 Aug 2023) Changed paths: M etc/mtree/BSD.usr.dist R share/man/man4/ahb.4 R share/man/man4/cm.4 R share/man/man4/digi.4 R share/man/man4/en.4 R share/man/man4/fatm.4 R share/man/man4/fpa.4 R share/man/man4/hatm.4 R share/man/man4/igb.4 R share/man/man4/ixgb.4 R share/man/man4/ixlv.4 R share/man/man4/jedec_ts.4 R share/man/man4/lmc.4 R share/man/man4/mcd.4 R share/man/man4/natm.4 R share/man/man4/natmip.4 R share/man/man4/ng_atm.4 R share/man/man4/nxge.4 R share/man/man4/patm.4 R share/man/man4/scd.4 R share/man/man4/si.4 R share/man/man4/spic.4 R share/man/man4/urtwn.4 R share/man/man4/urtwnfw.4 R share/man/man4/utopia.4 R share/man/man4/vxge.4 R share/man/man7/adding_user.7 M share/man/man9/atomic.9 R share/man/man9/boot.9 R share/man/man9/mbpool.9 R share/man/man9/utopia.9 R share/man/man9/vm_page_cache.9 Log Message: ----------- Remove some outdated directories from mtree Remove some old man pages found during test. From noreply at github.com Sat Aug 19 11:15:22 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:15:22 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] 5fb622: cleanup some entries Message-ID: Branch: refs/heads/master Home: https://github.com/MidnightBSD/src Commit: 5fb622ef331508fe3b51c1ef3b23470befaad8a2 https://github.com/MidnightBSD/src/commit/5fb622ef331508fe3b51c1ef3b23470befaad8a2 Author: Lucas Holt Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M etc/master.passwd M etc/mtree/BSD.var.dist Log Message: ----------- cleanup some entries From noreply at github.com Sat Aug 19 11:15:48 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:15:48 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] bd3df4: cleanup some entries Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: bd3df40b5e7bf8c596344b408f7e62db3647b223 https://github.com/MidnightBSD/src/commit/bd3df40b5e7bf8c596344b408f7e62db3647b223 Author: Lucas Holt Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M etc/master.passwd M etc/mtree/BSD.var.dist Log Message: ----------- cleanup some entries From noreply at github.com Sat Aug 19 11:19:48 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:19:48 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] 28cf23: midnightbsd Message-ID: Branch: refs/heads/master Home: https://github.com/MidnightBSD/src Commit: 28cf23baf44dd6cc1bc965e120c1348891dbb758 https://github.com/MidnightBSD/src/commit/28cf23baf44dd6cc1bc965e120c1348891dbb758 Author: Lucas Holt Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M contrib/mtree/mtree.h Log Message: ----------- midnightbsd From noreply at github.com Sat Aug 19 11:20:11 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:20:11 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] d8ad6d: midnightbsd Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: d8ad6d7f7e971462d31d82ea14a5ac98fa0b3935 https://github.com/MidnightBSD/src/commit/d8ad6d7f7e971462d31d82ea14a5ac98fa0b3935 Author: Lucas Holt Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M contrib/mtree/mtree.h Log Message: ----------- midnightbsd From noreply at github.com Sat Aug 19 11:25:39 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:25:39 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] ead348: frag6: Avoid a possible integer overflow in fragme... Message-ID: Branch: refs/heads/master Home: https://github.com/MidnightBSD/src Commit: ead348760876fa48eeb284065854a6ac80f1d0be https://github.com/MidnightBSD/src/commit/ead348760876fa48eeb284065854a6ac80f1d0be Author: Jonathan T. Looney Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netinet6/frag6.c Log Message: ----------- frag6: Avoid a possible integer overflow in fragment handling Reviewed by: kp, markj, bz Approved by: so Security: FreeBSD-SA-23:06.ipv6 Security: CVE-2023-3107 (cherry picked from commit ff3d1a3f9d71e706f320f51bae258e4e1a51b388) From noreply at github.com Sat Aug 19 11:26:25 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:26:25 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] f84046: frag6: Avoid a possible integer overflow in fragme... Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: f84046d89dc4dd732a789a95d9d10e13b0b76bff https://github.com/MidnightBSD/src/commit/f84046d89dc4dd732a789a95d9d10e13b0b76bff Author: Jonathan T. Looney Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netinet6/frag6.c Log Message: ----------- frag6: Avoid a possible integer overflow in fragment handling Reviewed by: kp, markj, bz Approved by: so Security: FreeBSD-SA-23:06.ipv6 Security: CVE-2023-3107 (cherry picked from commit ff3d1a3f9d71e706f320f51bae258e4e1a51b388) From noreply at github.com Sat Aug 19 11:30:18 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:30:18 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] 4e8fba: libpfct: ensure the initial allocation is large en... Message-ID: Branch: refs/heads/master Home: https://github.com/MidnightBSD/src Commit: 4e8fbab5324ecb3d5c077decd5c6f8f3df0cdd47 https://github.com/MidnightBSD/src/commit/4e8fbab5324ecb3d5c077decd5c6f8f3df0cdd47 Author: Kristof Provost Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M lib/libpfctl/libpfctl.c Log Message: ----------- libpfct: ensure the initial allocation is large enough Ensure that we allocate enough memory for the packed nvlist, no matter what size hint was provided. MFC after: 1 week Reported by: R. Christian McDonald Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 6422599e74db4bb8b47cead46760d96601d8396a) Commit: ba779dd85a1c4f37a72ab94b4b3ed671440d370e https://github.com/MidnightBSD/src/commit/ba779dd85a1c4f37a72ab94b4b3ed671440d370e Author: Mike Karels Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M usr.bin/netstat/if.c M usr.bin/netstat/netstat.1 Log Message: ----------- netstat -i: compute most field widths dynamically The network and address fields were sometimes truncated for netstat -i without -W, and often much too wide for netstat -i with the -W option. Fields such as normal packet counts often overflowed. As a result, columns didn't line up, and large white spaces made it harder to follow a line across the display. Change the code to compute the required field sizes for network, address, and various packet counts. Hoist the code to format network and address into a subroutine that can be called twice, once to measure the required field widths, and once to emit the values. Use separate field widths for input and output packets, byte counts, and error and drop counters. These are left at defaults (the preceding values) with the -h option, in which case the fields have a limited total width. An extra space is included between the Network and Address, which otherwise seemed too close. Change the mention of -W with -i in the man page to say that most field widths are computed dynamically in this case. Reviewed by: sjg, glebius Differential Revision: https://reviews.freebsd.org/D41160 (cherry picked from commit 372e3d561d82aba7a66fcd4ecb49a4d0a9f69345) Commit: 782dd6d889859c45de144897c125f41653568d82 https://github.com/MidnightBSD/src/commit/782dd6d889859c45de144897c125f41653568d82 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/sk/if_sk.c Log Message: ----------- sk(4): Fix a typo in a source code comment - s/nomral/normal/ (cherry picked from commit 135c2b71562f6a6b8e918cc66d5468342c198d02) Commit: ae50154952be078b6d9edf7c57d32828c0f54c06 https://github.com/MidnightBSD/src/commit/ae50154952be078b6d9edf7c57d32828c0f54c06 Author: Kristof Provost Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netpfil/pf/pf_norm.c Log Message: ----------- pf: handle multiple IPv6 fragment headers With 'scrub fragment reassemble' if a packet contains multiple IPv6 fragment headers we would reassemble the packet and immediately continue processing it. That is, we'd remove the first fragment header and expect the next header to be a final header (i.e. TCP, UDP, ICMPv6, ...). However, if it's another fragment header we'd not treat the packet correctly. That is, we'd fail to recognise the payload and treat it as if it were an IPv6 fragment rather than as its actual payload. Fix this by restarting the normalisation on the reassembled packet. If there are multiple fragment headers drop the packet. Reported by: Enrico Bassetti bassetti at di.uniroma1.it (NetSecurityLab @ Sapienza University of Rome) MFC after: instant Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 76afcbb52492f9b3e72ee7d4c4ed0a54c25e1c48) Commit: 0507c184aad97d0566450da31f647cc57d2f3bfa https://github.com/MidnightBSD/src/commit/0507c184aad97d0566450da31f647cc57d2f3bfa Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/fs/nfsserver/nfs_nfsdstate.c Log Message: ----------- nfsserver: Fix a typo in a source code comment - s/restared/restarted/ (cherry picked from commit 11892bc710a741a03735b164dc089d40d7d80374) Commit: 025c531c14ab107da509533633546098368c1aad https://github.com/MidnightBSD/src/commit/025c531c14ab107da509533633546098368c1aad Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netpfil/ipfilter/netinet/ip_state.c Log Message: ----------- netpfil: Fix a typo in a source code comment - s/interprted/interpreted/ (cherry picked from commit cfd05de1946799c6353b07da5d351027d8471203) Commit: eab468cfece27fe6a10c841574d9e3ba261204fd https://github.com/MidnightBSD/src/commit/eab468cfece27fe6a10c841574d9e3ba261204fd Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/aic7xxx/aic79xx.c M sys/dev/aic7xxx/aic7xxx.c Log Message: ----------- aic7xxx: Fix two typos in source code comments - s/reslection/reselection/ (cherry picked from commit 3514686b344da607515decb500018d25aadacd33) Commit: a4d77c5b0b661877ad9f7cadfce4d84496dc3487 https://github.com/MidnightBSD/src/commit/a4d77c5b0b661877ad9f7cadfce4d84496dc3487 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/sys/elf_common.h Log Message: ----------- elf(3): Fix a typo in a source code comment - s/speciaal/special/ (cherry picked from commit 2f0e0bd50633eafdfda503ec388151911e7383af) Commit: fee6b214b9fe1aa5c20fb8215e9d1cbd81139c70 https://github.com/MidnightBSD/src/commit/fee6b214b9fe1aa5c20fb8215e9d1cbd81139c70 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/amd64/linux32/linux32_machdep.c M sys/i386/linux/linux_machdep.c Log Message: ----------- linux(4): Fix two typos in source code comments - s/decriptors/descriptors/ (cherry picked from commit 29eab3e4e0c9a6e954b0ee858e3d4c2a9f283ea4) Commit: cad6285e207f48006a7ed3abbb1345614a6fd9f8 https://github.com/MidnightBSD/src/commit/cad6285e207f48006a7ed3abbb1345614a6fd9f8 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/vnic/thunder_mdio.c Log Message: ----------- vnic: Fix a typo in a source code comment - s/Enabele/Enable/ (cherry picked from commit b73763fc10d8000ec5c5682abccf6c8489eee8e3) Commit: 41d8dc7083555e3b361a13671b6165e9da4baece https://github.com/MidnightBSD/src/commit/41d8dc7083555e3b361a13671b6165e9da4baece Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/usb/video/udl.c Log Message: ----------- usb(4): Fix a typo in a source code comment - s/determin/determine/ (cherry picked from commit a924b48579c7a0c794431fbd3f540ce56c4cd662) Commit: 3407ae5ba05b39c39d0b89244de513b1f146dc31 https://github.com/MidnightBSD/src/commit/3407ae5ba05b39c39d0b89244de513b1f146dc31 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/et/if_et.c Log Message: ----------- et(4): Fix a typo in a source code comment - s/diabled/disabled/ (cherry picked from commit 734c9698d9ae83206a47daa40031a4de3bce9c28) Commit: 0c1c9d77a3607a0da2733276f0190232984ef2af https://github.com/MidnightBSD/src/commit/0c1c9d77a3607a0da2733276f0190232984ef2af Author: Konstantin Belousov Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/fs/cd9660/cd9660_rrip.c Log Message: ----------- cd9660: do not leak buffers in cd9660_rrip_loop() PR: 272856 (cherry picked from commit fa3cf6cdc68cb6d6f2c440f2653258d68eae1015) (cherry picked from commit 746c8f0cd7061bcda4bb68cb612827288459bee6) Commit: f5dfdc8cb56f809ffd78aaa0fc0c78b7a7d27115 https://github.com/MidnightBSD/src/commit/f5dfdc8cb56f809ffd78aaa0fc0c78b7a7d27115 Author: Andrew Turner Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M lib/msun/Makefile M lib/msun/aarch64/Makefile.inc M lib/msun/src/e_sqrt.c M lib/msun/src/e_sqrtf.c M lib/msun/src/s_fma.c M lib/msun/src/s_fmaf.c M lib/msun/src/s_fmax.c M lib/msun/src/s_fmaxf.c M lib/msun/src/s_fmin.c M lib/msun/src/s_fminf.c Log Message: ----------- Use a builtin where possible in msun Some of the functions in msun can be implemented using a compiler builtin function to generate a small number of instructions. Implement this support in fma, fmax, fmin, and sqrt on arm64. Care must be taken as the builtin can be implemented as a function call on some architectures that lack direct support. In these cases we need to use the original code path. As we don't set errno on failure build with -fno-math-errno so the toolchain doesn't convert a builtin into a function call when it detects a failure, e.g. gcc will add a call to sqrt when the input is negative leading to an infinite loop. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32801 (cherry picked from commit b2e843161dc3b79777e873183447c92ed9c3703a) Commit: 540b415017ea2ac11ea795582308944719026eb7 https://github.com/MidnightBSD/src/commit/540b415017ea2ac11ea795582308944719026eb7 Author: Steve Kargl Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M lib/msun/src/e_acos.c M lib/msun/src/e_acosf.c M lib/msun/src/e_acosh.c M lib/msun/src/e_acoshf.c M lib/msun/src/e_asin.c M lib/msun/src/e_asinf.c M lib/msun/src/e_atan2.c M lib/msun/src/e_atan2f.c M lib/msun/src/e_atanh.c M lib/msun/src/e_atanhf.c M lib/msun/src/e_cosh.c M lib/msun/src/e_coshf.c M lib/msun/src/e_exp.c M lib/msun/src/e_expf.c M lib/msun/src/e_fmod.c M lib/msun/src/e_fmodf.c M lib/msun/src/e_gamma.c M lib/msun/src/e_gamma_r.c M lib/msun/src/e_gammaf.c M lib/msun/src/e_gammaf_r.c M lib/msun/src/e_hypot.c M lib/msun/src/e_hypotf.c M lib/msun/src/e_j0.c M lib/msun/src/e_j0f.c M lib/msun/src/e_j1.c M lib/msun/src/e_j1f.c M lib/msun/src/e_jn.c M lib/msun/src/e_jnf.c M lib/msun/src/e_lgamma.c M lib/msun/src/e_lgamma_r.c M lib/msun/src/e_lgammaf.c M lib/msun/src/e_lgammaf_r.c M lib/msun/src/e_log.c M lib/msun/src/e_log10.c M lib/msun/src/e_log10f.c M lib/msun/src/e_log2.c M lib/msun/src/e_log2f.c M lib/msun/src/e_logf.c M lib/msun/src/e_pow.c M lib/msun/src/e_powf.c M lib/msun/src/e_remainder.c M lib/msun/src/e_remainderf.c M lib/msun/src/e_scalb.c M lib/msun/src/e_scalbf.c M lib/msun/src/e_sinh.c M lib/msun/src/e_sinhf.c M lib/msun/src/e_sqrt.c M lib/msun/src/e_sqrtf.c M lib/msun/src/math_private.h M lib/msun/src/s_asinh.c M lib/msun/src/s_asinhf.c M lib/msun/src/s_erf.c M lib/msun/src/s_significand.c M lib/msun/src/s_significandf.c Log Message: ----------- Clean up libm use of the __ieee754_ prefix This removes the __ieee754_ prefix from a number of the math functions. msun/src/math_private.h contains the statement that /* * ieee style elementary functions * * We rename functions here to improve other sources' diffability * against fdlibm. */ #define __ieee754_sqrt sqrt ... Here, fdlibm refers to https://netlib.org/fdlibm. It is seen from https://netlib.org/fdlibm/readme that this prefix was used to differentiate between different standards: Wrapper functions will twist the result of the ieee754 function to comply to the standard specified by the value of _LIB_VERSION if _LIB_VERSION = _IEEE_, return the ieee754 result; if _LIB_VERSION = _SVID_, return SVID result; if _LIB_VERSION = _XOPEN_, return XOPEN result; if _LIB_VERSION = _POSIX_, return POSIX/ANSI result. (These are macros, see fdlibm.h for their definition.) AFAICT, FreeBSD has never supported these wrappers. In addition, as C99, principally the long double, functions were added to libm, this convention was not maintained. Given that only 148 of 324 files under lib/msun contain a "Copyright (C) 1993 by Sun Microsystems" statement, the removal of the __ieee754_ prefix provides consistency across all source files. The last time someone compared lib/msun to fdlibm appears to be commit 3f70824172feb82ea3dcdb3866b54fe0eb7cd890 Author: David Schultz Date: Fri Feb 4 18:26:06 2005 +0000 Reduce diffs against vendor source (Sun fdlibm 5.3). The most recent fdlibm RCS string that appears in a Sun Microsystem copyrighted file is date "95/01/18". With Oracle Corporation's acquisition of Sun Microsystems in 2009, it is unlikely that fdlibm will ever be updated. A search for fdlibm at https://opensource.oracle.com/ yields no hits. Finally, OpenBSD removed the use of this prefix over 21 years ago. pSee revision 1.6 of OpenBSD's math_private.h. Note: this does not drop the __ieee754_ prefix from the trigonometric argument reduction functions, e.g., __ieee754_rem_pio2. These functions are internal to the libm and exported through Symbol.map; and thus, reserved for the implementation. PR: 272783 MFC after: 1 week (cherry picked from commit 99843eb89954dac76afe7cf18d962eddfe7a7987) Commit: c1e051b79baafdea9ff48ada054ea77c6696d7bf https://github.com/MidnightBSD/src/commit/c1e051b79baafdea9ff48ada054ea77c6696d7bf Author: Richard Scheffenegger Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netinet/tcp_input.c M sys/netinet/tcp_syncache.c Log Message: ----------- tcp: Handle in SYN-RCVD Patch base stack to correctly handle the RST bit independently of other header flags per TCP RFC. MFC after: 1 week Reviewed By: tuexen, #transport Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D40982 (cherry picked from commit b352ef58c29b1f2967e358c147e0f7faf8cfbef3) Commit: 6cf93921cb4b7e923fc05d5b4ec62972db1833a0 https://github.com/MidnightBSD/src/commit/6cf93921cb4b7e923fc05d5b4ec62972db1833a0 Author: Kevin Bowling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/net/if_vlan.c Log Message: ----------- vlan: Respect IFCAP_LRO mask vlan_capabilities(), used by the IFCAP ioctl, was not respecting the IFCAP_LRO bit if it was masked by the requestor. This prevented if_bridge(4) from automasking LRO with a message like: bridge0: can't disable some capabilities on em3.11: 0x400 This also prevented manually disabling LRO from any vlan interface. PR: 254596 Reported by: Paul Vixie (cherry picked from commit b1a39c31a3569bd045a0f40057c3773fc8166f6d) Commit: 97f232a3dd46d54bc225d9f1241c2d94c37cb3c8 https://github.com/MidnightBSD/src/commit/97f232a3dd46d54bc225d9f1241c2d94c37cb3c8 Author: Mike Karels Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/md/md.c Log Message: ----------- md driver compat32: fix structure padding for arm, powerpc Because the 32-bit md_ioctl structure contains 64-bit members, arm and powerpc add padding to a multiple of 8. i386 doesn't do this. The md_ioctl32 definition was correct for amd64/i386 without padding, but wrong for arm64 and powerpc64. Make __packed__ conditional on __amd64__, and test for the expected size on non-amd64. Note that mdconfig is used in the ATF test suite. Note, I verified the structure size for powerpc, but was unable to test. Reviewed by: jrtc27 Differential Revision: https://reviews.freebsd.org/D41339 Discussed with: jhibbits (cherry picked from commit 58a46cfd751ac726ddca8544bf73a290b0154a57) Commit: 27a39c37080b21afd11a888fc85d0531c1adb3b1 https://github.com/MidnightBSD/src/commit/27a39c37080b21afd11a888fc85d0531c1adb3b1 Author: Eugene Grosbein Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M libexec/tftpd/tftpd.8 M libexec/tftpd/tftpd.c Log Message: ----------- tftpd: introduce new option -S Historically, tftpd disallowed write requests to existing files that are not publicly writable. Such requirement is questionable at least. Let us make it possible to run tftpd in chrooted environment keeping files non-world writable. New option -S enables write requests to existing files for chrooted run according to generic file permissions. It is ignored unless tftpd runs chrooted. Requested by: marck Differential: https://reviews.freebsd.org/D41090 (based on) (cherry picked from commit 273a307d0b80743fb08e23237b3f74dc94a8fa2a) (cherry picked from commit 03c2616dc530e5b23f06f9aa421012154590e578) Compare: https://github.com/MidnightBSD/src/compare/ead348760876...27a39c37080b From noreply at github.com Sat Aug 19 11:33:38 2023 From: noreply at github.com (Kristof Provost) Date: Sat, 19 Aug 2023 08:33:38 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] f70e01: libpfct: ensure the initial allocation is large en... Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: f70e017df7f4bbceef33a1076eef930750b298ae https://github.com/MidnightBSD/src/commit/f70e017df7f4bbceef33a1076eef930750b298ae Author: Kristof Provost Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M lib/libpfctl/libpfctl.c Log Message: ----------- libpfct: ensure the initial allocation is large enough Ensure that we allocate enough memory for the packed nvlist, no matter what size hint was provided. MFC after: 1 week Reported by: R. Christian McDonald Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 6422599e74db4bb8b47cead46760d96601d8396a) From noreply at github.com Sat Aug 19 11:36:46 2023 From: noreply at github.com (Gordon Bergling) Date: Sat, 19 Aug 2023 08:36:46 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] 9e08ff: netstat -i: compute most field widths dynamically Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: 9e08ff7c6f6df119837576c0a7a9d4242187dbc7 https://github.com/MidnightBSD/src/commit/9e08ff7c6f6df119837576c0a7a9d4242187dbc7 Author: Mike Karels Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M usr.bin/netstat/if.c M usr.bin/netstat/netstat.1 Log Message: ----------- netstat -i: compute most field widths dynamically The network and address fields were sometimes truncated for netstat -i without -W, and often much too wide for netstat -i with the -W option. Fields such as normal packet counts often overflowed. As a result, columns didn't line up, and large white spaces made it harder to follow a line across the display. Change the code to compute the required field sizes for network, address, and various packet counts. Hoist the code to format network and address into a subroutine that can be called twice, once to measure the required field widths, and once to emit the values. Use separate field widths for input and output packets, byte counts, and error and drop counters. These are left at defaults (the preceding values) with the -h option, in which case the fields have a limited total width. An extra space is included between the Network and Address, which otherwise seemed too close. Change the mention of -W with -i in the man page to say that most field widths are computed dynamically in this case. Reviewed by: sjg, glebius Differential Revision: https://reviews.freebsd.org/D41160 (cherry picked from commit 372e3d561d82aba7a66fcd4ecb49a4d0a9f69345) Commit: 9431b464bc1d4e1519feb4a336b9ed68d5541af7 https://github.com/MidnightBSD/src/commit/9431b464bc1d4e1519feb4a336b9ed68d5541af7 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/sk/if_sk.c Log Message: ----------- sk(4): Fix a typo in a source code comment - s/nomral/normal/ (cherry picked from commit 135c2b71562f6a6b8e918cc66d5468342c198d02) Commit: 1e9d2512eb427a87a10b1b5f403cc2069dcc919c https://github.com/MidnightBSD/src/commit/1e9d2512eb427a87a10b1b5f403cc2069dcc919c Author: Kristof Provost Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netpfil/pf/pf_norm.c Log Message: ----------- pf: handle multiple IPv6 fragment headers With 'scrub fragment reassemble' if a packet contains multiple IPv6 fragment headers we would reassemble the packet and immediately continue processing it. That is, we'd remove the first fragment header and expect the next header to be a final header (i.e. TCP, UDP, ICMPv6, ...). However, if it's another fragment header we'd not treat the packet correctly. That is, we'd fail to recognise the payload and treat it as if it were an IPv6 fragment rather than as its actual payload. Fix this by restarting the normalisation on the reassembled packet. If there are multiple fragment headers drop the packet. Reported by: Enrico Bassetti bassetti at di.uniroma1.it (NetSecurityLab @ Sapienza University of Rome) MFC after: instant Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 76afcbb52492f9b3e72ee7d4c4ed0a54c25e1c48) Commit: 048dec733372bf4c80e1ebba8bc954f44b1da8d1 https://github.com/MidnightBSD/src/commit/048dec733372bf4c80e1ebba8bc954f44b1da8d1 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/fs/nfsserver/nfs_nfsdstate.c Log Message: ----------- nfsserver: Fix a typo in a source code comment - s/restared/restarted/ (cherry picked from commit 11892bc710a741a03735b164dc089d40d7d80374) Commit: 1daa8a1104f597869e2251f17c00a9473d69c1f6 https://github.com/MidnightBSD/src/commit/1daa8a1104f597869e2251f17c00a9473d69c1f6 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netpfil/ipfilter/netinet/ip_state.c Log Message: ----------- netpfil: Fix a typo in a source code comment - s/interprted/interpreted/ (cherry picked from commit cfd05de1946799c6353b07da5d351027d8471203) Commit: db4d5cfdc2f8cf194d69ee8d068da9c353fed24c https://github.com/MidnightBSD/src/commit/db4d5cfdc2f8cf194d69ee8d068da9c353fed24c Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/aic7xxx/aic79xx.c M sys/dev/aic7xxx/aic7xxx.c Log Message: ----------- aic7xxx: Fix two typos in source code comments - s/reslection/reselection/ (cherry picked from commit 3514686b344da607515decb500018d25aadacd33) Compare: https://github.com/MidnightBSD/src/compare/f70e017df7f4...db4d5cfdc2f8 From noreply at github.com Sat Aug 19 11:39:04 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 08:39:04 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] bdc351: elf(3): Fix a typo in a source code comment Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: bdc351047c13f273132f2baae5aa22072f8fe122 https://github.com/MidnightBSD/src/commit/bdc351047c13f273132f2baae5aa22072f8fe122 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/sys/elf_common.h Log Message: ----------- elf(3): Fix a typo in a source code comment - s/speciaal/special/ (cherry picked from commit 2f0e0bd50633eafdfda503ec388151911e7383af) Commit: 58003b17663a1d15bf1c83921f350486726c69c5 https://github.com/MidnightBSD/src/commit/58003b17663a1d15bf1c83921f350486726c69c5 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/amd64/linux32/linux32_machdep.c M sys/i386/linux/linux_machdep.c Log Message: ----------- linux(4): Fix two typos in source code comments - s/decriptors/descriptors/ (cherry picked from commit 29eab3e4e0c9a6e954b0ee858e3d4c2a9f283ea4) Commit: 1df5f05c8862d2a33a784cd6abf38e0d936aa83b https://github.com/MidnightBSD/src/commit/1df5f05c8862d2a33a784cd6abf38e0d936aa83b Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/vnic/thunder_mdio.c Log Message: ----------- vnic: Fix a typo in a source code comment - s/Enabele/Enable/ (cherry picked from commit b73763fc10d8000ec5c5682abccf6c8489eee8e3) Commit: a7e58208b7949e052081ced6e3fba4751cfb282c https://github.com/MidnightBSD/src/commit/a7e58208b7949e052081ced6e3fba4751cfb282c Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/usb/video/udl.c Log Message: ----------- usb(4): Fix a typo in a source code comment - s/determin/determine/ (cherry picked from commit a924b48579c7a0c794431fbd3f540ce56c4cd662) Commit: fb49670773da57492a49b8874d1dca6d4f5a47c0 https://github.com/MidnightBSD/src/commit/fb49670773da57492a49b8874d1dca6d4f5a47c0 Author: Gordon Bergling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/et/if_et.c Log Message: ----------- et(4): Fix a typo in a source code comment - s/diabled/disabled/ (cherry picked from commit 734c9698d9ae83206a47daa40031a4de3bce9c28) Commit: 709c762fee6eb7675f20a661a90776915df59c89 https://github.com/MidnightBSD/src/commit/709c762fee6eb7675f20a661a90776915df59c89 Author: Konstantin Belousov Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/fs/cd9660/cd9660_rrip.c Log Message: ----------- cd9660: do not leak buffers in cd9660_rrip_loop() PR: 272856 (cherry picked from commit fa3cf6cdc68cb6d6f2c440f2653258d68eae1015) (cherry picked from commit 746c8f0cd7061bcda4bb68cb612827288459bee6) Commit: 63fa8040c248506c4f8e935d60a3e7d385545e07 https://github.com/MidnightBSD/src/commit/63fa8040c248506c4f8e935d60a3e7d385545e07 Author: Andrew Turner Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M lib/msun/Makefile M lib/msun/aarch64/Makefile.inc M lib/msun/src/e_sqrt.c M lib/msun/src/e_sqrtf.c M lib/msun/src/s_fma.c M lib/msun/src/s_fmaf.c M lib/msun/src/s_fmax.c M lib/msun/src/s_fmaxf.c M lib/msun/src/s_fmin.c M lib/msun/src/s_fminf.c Log Message: ----------- Use a builtin where possible in msun Some of the functions in msun can be implemented using a compiler builtin function to generate a small number of instructions. Implement this support in fma, fmax, fmin, and sqrt on arm64. Care must be taken as the builtin can be implemented as a function call on some architectures that lack direct support. In these cases we need to use the original code path. As we don't set errno on failure build with -fno-math-errno so the toolchain doesn't convert a builtin into a function call when it detects a failure, e.g. gcc will add a call to sqrt when the input is negative leading to an infinite loop. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32801 (cherry picked from commit b2e843161dc3b79777e873183447c92ed9c3703a) Commit: a6b405048432fbdff6263a61e980a0f8137c186f https://github.com/MidnightBSD/src/commit/a6b405048432fbdff6263a61e980a0f8137c186f Author: Steve Kargl Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M lib/msun/src/e_acos.c M lib/msun/src/e_acosf.c M lib/msun/src/e_acosh.c M lib/msun/src/e_acoshf.c M lib/msun/src/e_asin.c M lib/msun/src/e_asinf.c M lib/msun/src/e_atan2.c M lib/msun/src/e_atan2f.c M lib/msun/src/e_atanh.c M lib/msun/src/e_atanhf.c M lib/msun/src/e_cosh.c M lib/msun/src/e_coshf.c M lib/msun/src/e_exp.c M lib/msun/src/e_expf.c M lib/msun/src/e_fmod.c M lib/msun/src/e_fmodf.c M lib/msun/src/e_gamma.c M lib/msun/src/e_gamma_r.c M lib/msun/src/e_gammaf.c M lib/msun/src/e_gammaf_r.c M lib/msun/src/e_hypot.c M lib/msun/src/e_hypotf.c M lib/msun/src/e_j0.c M lib/msun/src/e_j0f.c M lib/msun/src/e_j1.c M lib/msun/src/e_j1f.c M lib/msun/src/e_jn.c M lib/msun/src/e_jnf.c M lib/msun/src/e_lgamma.c M lib/msun/src/e_lgamma_r.c M lib/msun/src/e_lgammaf.c M lib/msun/src/e_lgammaf_r.c M lib/msun/src/e_log.c M lib/msun/src/e_log10.c M lib/msun/src/e_log10f.c M lib/msun/src/e_log2.c M lib/msun/src/e_log2f.c M lib/msun/src/e_logf.c M lib/msun/src/e_pow.c M lib/msun/src/e_powf.c M lib/msun/src/e_remainder.c M lib/msun/src/e_remainderf.c M lib/msun/src/e_scalb.c M lib/msun/src/e_scalbf.c M lib/msun/src/e_sinh.c M lib/msun/src/e_sinhf.c M lib/msun/src/e_sqrt.c M lib/msun/src/e_sqrtf.c M lib/msun/src/math_private.h M lib/msun/src/s_asinh.c M lib/msun/src/s_asinhf.c M lib/msun/src/s_erf.c M lib/msun/src/s_significand.c M lib/msun/src/s_significandf.c Log Message: ----------- Clean up libm use of the __ieee754_ prefix This removes the __ieee754_ prefix from a number of the math functions. msun/src/math_private.h contains the statement that /* * ieee style elementary functions * * We rename functions here to improve other sources' diffability * against fdlibm. */ #define __ieee754_sqrt sqrt ... Here, fdlibm refers to https://netlib.org/fdlibm. It is seen from https://netlib.org/fdlibm/readme that this prefix was used to differentiate between different standards: Wrapper functions will twist the result of the ieee754 function to comply to the standard specified by the value of _LIB_VERSION if _LIB_VERSION = _IEEE_, return the ieee754 result; if _LIB_VERSION = _SVID_, return SVID result; if _LIB_VERSION = _XOPEN_, return XOPEN result; if _LIB_VERSION = _POSIX_, return POSIX/ANSI result. (These are macros, see fdlibm.h for their definition.) AFAICT, FreeBSD has never supported these wrappers. In addition, as C99, principally the long double, functions were added to libm, this convention was not maintained. Given that only 148 of 324 files under lib/msun contain a "Copyright (C) 1993 by Sun Microsystems" statement, the removal of the __ieee754_ prefix provides consistency across all source files. The last time someone compared lib/msun to fdlibm appears to be commit 3f70824172feb82ea3dcdb3866b54fe0eb7cd890 Author: David Schultz Date: Fri Feb 4 18:26:06 2005 +0000 Reduce diffs against vendor source (Sun fdlibm 5.3). The most recent fdlibm RCS string that appears in a Sun Microsystem copyrighted file is date "95/01/18". With Oracle Corporation's acquisition of Sun Microsystems in 2009, it is unlikely that fdlibm will ever be updated. A search for fdlibm at https://opensource.oracle.com/ yields no hits. Finally, OpenBSD removed the use of this prefix over 21 years ago. pSee revision 1.6 of OpenBSD's math_private.h. Note: this does not drop the __ieee754_ prefix from the trigonometric argument reduction functions, e.g., __ieee754_rem_pio2. These functions are internal to the libm and exported through Symbol.map; and thus, reserved for the implementation. PR: 272783 MFC after: 1 week (cherry picked from commit 99843eb89954dac76afe7cf18d962eddfe7a7987) Commit: 09b467131a0f5af7b837a6664f24dcd2c1ea1a08 https://github.com/MidnightBSD/src/commit/09b467131a0f5af7b837a6664f24dcd2c1ea1a08 Author: Richard Scheffenegger Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/netinet/tcp_input.c M sys/netinet/tcp_syncache.c Log Message: ----------- tcp: Handle in SYN-RCVD Patch base stack to correctly handle the RST bit independently of other header flags per TCP RFC. MFC after: 1 week Reviewed By: tuexen, #transport Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D40982 (cherry picked from commit b352ef58c29b1f2967e358c147e0f7faf8cfbef3) Commit: 35a48819281f280c1485f378c2ccab6003756a75 https://github.com/MidnightBSD/src/commit/35a48819281f280c1485f378c2ccab6003756a75 Author: Kevin Bowling Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/net/if_vlan.c Log Message: ----------- vlan: Respect IFCAP_LRO mask vlan_capabilities(), used by the IFCAP ioctl, was not respecting the IFCAP_LRO bit if it was masked by the requestor. This prevented if_bridge(4) from automasking LRO with a message like: bridge0: can't disable some capabilities on em3.11: 0x400 This also prevented manually disabling LRO from any vlan interface. PR: 254596 Reported by: Paul Vixie (cherry picked from commit b1a39c31a3569bd045a0f40057c3773fc8166f6d) Commit: f2caed2f77a5d9906f8eb864f80e2806c15fd700 https://github.com/MidnightBSD/src/commit/f2caed2f77a5d9906f8eb864f80e2806c15fd700 Author: Mike Karels Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M sys/dev/md/md.c Log Message: ----------- md driver compat32: fix structure padding for arm, powerpc Because the 32-bit md_ioctl structure contains 64-bit members, arm and powerpc add padding to a multiple of 8. i386 doesn't do this. The md_ioctl32 definition was correct for amd64/i386 without padding, but wrong for arm64 and powerpc64. Make __packed__ conditional on __amd64__, and test for the expected size on non-amd64. Note that mdconfig is used in the ATF test suite. Note, I verified the structure size for powerpc, but was unable to test. Reviewed by: jrtc27 Differential Revision: https://reviews.freebsd.org/D41339 Discussed with: jhibbits (cherry picked from commit 58a46cfd751ac726ddca8544bf73a290b0154a57) Commit: 34b30dcf70055eecdfd950d4422c486822522fd6 https://github.com/MidnightBSD/src/commit/34b30dcf70055eecdfd950d4422c486822522fd6 Author: Eugene Grosbein Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M libexec/tftpd/tftpd.8 M libexec/tftpd/tftpd.c Log Message: ----------- tftpd: introduce new option -S Historically, tftpd disallowed write requests to existing files that are not publicly writable. Such requirement is questionable at least. Let us make it possible to run tftpd in chrooted environment keeping files non-world writable. New option -S enables write requests to existing files for chrooted run according to generic file permissions. It is ignored unless tftpd runs chrooted. Requested by: marck Differential: https://reviews.freebsd.org/D41090 (based on) (cherry picked from commit 273a307d0b80743fb08e23237b3f74dc94a8fa2a) (cherry picked from commit 03c2616dc530e5b23f06f9aa421012154590e578) Compare: https://github.com/MidnightBSD/src/compare/db4d5cfdc2f8...34b30dcf7005 From noreply at github.com Sat Aug 19 12:45:33 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 09:45:33 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] d2e2e3: weird Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: d2e2e366c8497e2e78a8ccbb5b1822e2f022c9de https://github.com/MidnightBSD/src/commit/d2e2e366c8497e2e78a8ccbb5b1822e2f022c9de Author: Lucas Holt Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M libexec/tftpd/tftpd.c Log Message: ----------- weird From noreply at github.com Sat Aug 19 12:45:48 2023 From: noreply at github.com (Lucas Holt) Date: Sat, 19 Aug 2023 09:45:48 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] d6edc5: weird Message-ID: Branch: refs/heads/master Home: https://github.com/MidnightBSD/src Commit: d6edc566b11380cdcb6b5506f7e6337e1437f680 https://github.com/MidnightBSD/src/commit/d6edc566b11380cdcb6b5506f7e6337e1437f680 Author: Lucas Holt Date: 2023-08-19 (Sat, 19 Aug 2023) Changed paths: M libexec/tftpd/tftpd.c Log Message: ----------- weird From noreply at github.com Sun Aug 20 23:36:43 2023 From: noreply at github.com (Lucas Holt) Date: Sun, 20 Aug 2023 20:36:43 -0700 Subject: [Midnightbsd-cvs] [MidnightBSD/src] 948783: revert Message-ID: Branch: refs/heads/stable/3.1 Home: https://github.com/MidnightBSD/src Commit: 948783fcc6c8f307313afe5303ba25d024e4e2b8 https://github.com/MidnightBSD/src/commit/948783fcc6c8f307313afe5303ba25d024e4e2b8 Author: Lucas Holt Date: 2023-08-20 (Sun, 20 Aug 2023) Changed paths: M etc/master.passwd Log Message: ----------- revert