[Midnightbsd-cvs] [MidnightBSD/src] bdc351: elf(3): Fix a typo in a source code comment

Lucas Holt noreply at github.com
Sat Aug 19 11:39:04 EDT 2023


  Branch: refs/heads/stable/3.1
  Home:   https://github.com/MidnightBSD/src
  Commit: bdc351047c13f273132f2baae5aa22072f8fe122
      https://github.com/MidnightBSD/src/commit/bdc351047c13f273132f2baae5aa22072f8fe122
  Author: Gordon Bergling <gbe at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/sys/elf_common.h

  Log Message:
  -----------
  elf(3): Fix a typo in a source code comment

- s/speciaal/special/

(cherry picked from commit 2f0e0bd50633eafdfda503ec388151911e7383af)


  Commit: 58003b17663a1d15bf1c83921f350486726c69c5
      https://github.com/MidnightBSD/src/commit/58003b17663a1d15bf1c83921f350486726c69c5
  Author: Gordon Bergling <gbe at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/amd64/linux32/linux32_machdep.c
    M sys/i386/linux/linux_machdep.c

  Log Message:
  -----------
  linux(4): Fix two typos in source code comments

- s/decriptors/descriptors/

(cherry picked from commit 29eab3e4e0c9a6e954b0ee858e3d4c2a9f283ea4)


  Commit: 1df5f05c8862d2a33a784cd6abf38e0d936aa83b
      https://github.com/MidnightBSD/src/commit/1df5f05c8862d2a33a784cd6abf38e0d936aa83b
  Author: Gordon Bergling <gbe at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/dev/vnic/thunder_mdio.c

  Log Message:
  -----------
  vnic: Fix a typo in a source code comment

- s/Enabele/Enable/

(cherry picked from commit b73763fc10d8000ec5c5682abccf6c8489eee8e3)


  Commit: a7e58208b7949e052081ced6e3fba4751cfb282c
      https://github.com/MidnightBSD/src/commit/a7e58208b7949e052081ced6e3fba4751cfb282c
  Author: Gordon Bergling <gbe at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/dev/usb/video/udl.c

  Log Message:
  -----------
  usb(4): Fix a typo in a source code comment

- s/determin/determine/

(cherry picked from commit a924b48579c7a0c794431fbd3f540ce56c4cd662)


  Commit: fb49670773da57492a49b8874d1dca6d4f5a47c0
      https://github.com/MidnightBSD/src/commit/fb49670773da57492a49b8874d1dca6d4f5a47c0
  Author: Gordon Bergling <gbe at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/dev/et/if_et.c

  Log Message:
  -----------
  et(4): Fix a typo in a source code comment

- s/diabled/disabled/

(cherry picked from commit 734c9698d9ae83206a47daa40031a4de3bce9c28)


  Commit: 709c762fee6eb7675f20a661a90776915df59c89
      https://github.com/MidnightBSD/src/commit/709c762fee6eb7675f20a661a90776915df59c89
  Author: Konstantin Belousov <kib at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/fs/cd9660/cd9660_rrip.c

  Log Message:
  -----------
  cd9660: do not leak buffers in cd9660_rrip_loop()

PR:	272856

(cherry picked from commit fa3cf6cdc68cb6d6f2c440f2653258d68eae1015)
(cherry picked from commit 746c8f0cd7061bcda4bb68cb612827288459bee6)


  Commit: 63fa8040c248506c4f8e935d60a3e7d385545e07
      https://github.com/MidnightBSD/src/commit/63fa8040c248506c4f8e935d60a3e7d385545e07
  Author: Andrew Turner <andrew at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M lib/msun/Makefile
    M lib/msun/aarch64/Makefile.inc
    M lib/msun/src/e_sqrt.c
    M lib/msun/src/e_sqrtf.c
    M lib/msun/src/s_fma.c
    M lib/msun/src/s_fmaf.c
    M lib/msun/src/s_fmax.c
    M lib/msun/src/s_fmaxf.c
    M lib/msun/src/s_fmin.c
    M lib/msun/src/s_fminf.c

  Log Message:
  -----------
  Use a builtin where possible in msun

Some of the functions in msun can be implemented using a compiler
builtin function to generate a small number of instructions. Implement
this support in fma, fmax, fmin, and sqrt on arm64.

Care must be taken as the builtin can be implemented as a function
call on some architectures that lack direct support. In these cases
we need to use the original code path.

As we don't set errno on failure build with -fno-math-errno so the
toolchain doesn't convert a builtin into a function call when it
detects a failure, e.g. gcc will add a call to sqrt when the input
is negative leading to an infinite loop.

Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D32801

(cherry picked from commit b2e843161dc3b79777e873183447c92ed9c3703a)


  Commit: a6b405048432fbdff6263a61e980a0f8137c186f
      https://github.com/MidnightBSD/src/commit/a6b405048432fbdff6263a61e980a0f8137c186f
  Author: Steve Kargl <kargl at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M lib/msun/src/e_acos.c
    M lib/msun/src/e_acosf.c
    M lib/msun/src/e_acosh.c
    M lib/msun/src/e_acoshf.c
    M lib/msun/src/e_asin.c
    M lib/msun/src/e_asinf.c
    M lib/msun/src/e_atan2.c
    M lib/msun/src/e_atan2f.c
    M lib/msun/src/e_atanh.c
    M lib/msun/src/e_atanhf.c
    M lib/msun/src/e_cosh.c
    M lib/msun/src/e_coshf.c
    M lib/msun/src/e_exp.c
    M lib/msun/src/e_expf.c
    M lib/msun/src/e_fmod.c
    M lib/msun/src/e_fmodf.c
    M lib/msun/src/e_gamma.c
    M lib/msun/src/e_gamma_r.c
    M lib/msun/src/e_gammaf.c
    M lib/msun/src/e_gammaf_r.c
    M lib/msun/src/e_hypot.c
    M lib/msun/src/e_hypotf.c
    M lib/msun/src/e_j0.c
    M lib/msun/src/e_j0f.c
    M lib/msun/src/e_j1.c
    M lib/msun/src/e_j1f.c
    M lib/msun/src/e_jn.c
    M lib/msun/src/e_jnf.c
    M lib/msun/src/e_lgamma.c
    M lib/msun/src/e_lgamma_r.c
    M lib/msun/src/e_lgammaf.c
    M lib/msun/src/e_lgammaf_r.c
    M lib/msun/src/e_log.c
    M lib/msun/src/e_log10.c
    M lib/msun/src/e_log10f.c
    M lib/msun/src/e_log2.c
    M lib/msun/src/e_log2f.c
    M lib/msun/src/e_logf.c
    M lib/msun/src/e_pow.c
    M lib/msun/src/e_powf.c
    M lib/msun/src/e_remainder.c
    M lib/msun/src/e_remainderf.c
    M lib/msun/src/e_scalb.c
    M lib/msun/src/e_scalbf.c
    M lib/msun/src/e_sinh.c
    M lib/msun/src/e_sinhf.c
    M lib/msun/src/e_sqrt.c
    M lib/msun/src/e_sqrtf.c
    M lib/msun/src/math_private.h
    M lib/msun/src/s_asinh.c
    M lib/msun/src/s_asinhf.c
    M lib/msun/src/s_erf.c
    M lib/msun/src/s_significand.c
    M lib/msun/src/s_significandf.c

  Log Message:
  -----------
  Clean up libm use of the __ieee754_ prefix

This removes the __ieee754_ prefix from a number of the math functions.
msun/src/math_private.h contains the statement that

  /*
   * ieee style elementary functions
   *
   * We rename functions here to improve other sources' diffability
   * against fdlibm.
   */
   #define        __ieee754_sqrt  sqrt
   ...

Here, fdlibm refers to https://netlib.org/fdlibm. It is seen from
https://netlib.org/fdlibm/readme that this prefix was used to
differentiate between different standards:

   Wrapper functions will twist the result of the ieee754
   function to comply to the standard specified by the value
   of _LIB_VERSION
      if _LIB_VERSION = _IEEE_, return the ieee754 result;
      if _LIB_VERSION = _SVID_, return SVID result;
      if _LIB_VERSION = _XOPEN_, return XOPEN result;
      if _LIB_VERSION = _POSIX_, return POSIX/ANSI result.
   (These are macros, see fdlibm.h for their definition.)

AFAICT, FreeBSD has never supported these wrappers. In addition, as C99,
principally the long double, functions were added to libm, this
convention was not maintained. Given that only 148 of 324 files under
lib/msun contain a "Copyright (C) 1993 by Sun Microsystems" statement,
the removal of the __ieee754_ prefix provides consistency across all
source files.

The last time someone compared lib/msun to fdlibm appears to be

  commit 3f70824172feb82ea3dcdb3866b54fe0eb7cd890
  Author: David Schultz <das at FreeBSD.org>
  Date:   Fri Feb 4 18:26:06 2005 +0000

  Reduce diffs against vendor source (Sun fdlibm 5.3).

The most recent fdlibm RCS string that appears in a Sun Microsystem
copyrighted file is date "95/01/18". With Oracle Corporation's
acquisition of Sun Microsystems in 2009, it is unlikely that fdlibm will
ever be updated. A search for fdlibm at https://opensource.oracle.com/
yields no hits.

Finally, OpenBSD removed the use of this prefix over 21 years ago. pSee
revision 1.6 of OpenBSD's math_private.h.

Note: this does not drop the __ieee754_ prefix from the trigonometric
argument reduction functions, e.g., __ieee754_rem_pio2. These functions
are internal to the libm and exported through Symbol.map; and thus,
reserved for the implementation.

PR:		272783
MFC after:	1 week

(cherry picked from commit 99843eb89954dac76afe7cf18d962eddfe7a7987)


  Commit: 09b467131a0f5af7b837a6664f24dcd2c1ea1a08
      https://github.com/MidnightBSD/src/commit/09b467131a0f5af7b837a6664f24dcd2c1ea1a08
  Author: Richard Scheffenegger <rscheff at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/netinet/tcp_input.c
    M sys/netinet/tcp_syncache.c

  Log Message:
  -----------
  tcp: Handle <RST,ACK> in SYN-RCVD

Patch base stack to correctly handle the RST bit independently
of other header flags per TCP RFC.

MFC after: 1 week
Reviewed By: tuexen, #transport
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D40982

(cherry picked from commit b352ef58c29b1f2967e358c147e0f7faf8cfbef3)


  Commit: 35a48819281f280c1485f378c2ccab6003756a75
      https://github.com/MidnightBSD/src/commit/35a48819281f280c1485f378c2ccab6003756a75
  Author: Kevin Bowling <kbowling at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/net/if_vlan.c

  Log Message:
  -----------
  vlan: Respect IFCAP_LRO mask

vlan_capabilities(), used by the IFCAP ioctl, was not respecting the
IFCAP_LRO bit if it was masked by the requestor.

This prevented if_bridge(4) from automasking LRO with a message like:
bridge0: can't disable some capabilities on em3.11: 0x400

This also prevented manually disabling LRO from any vlan interface.

PR:		254596
Reported by:	Paul Vixie <paul at redbarn.org>

(cherry picked from commit b1a39c31a3569bd045a0f40057c3773fc8166f6d)


  Commit: f2caed2f77a5d9906f8eb864f80e2806c15fd700
      https://github.com/MidnightBSD/src/commit/f2caed2f77a5d9906f8eb864f80e2806c15fd700
  Author: Mike Karels <karels at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M sys/dev/md/md.c

  Log Message:
  -----------
  md driver compat32: fix structure padding for arm, powerpc

Because the 32-bit md_ioctl structure contains 64-bit members, arm
and powerpc add padding to a multiple of 8.  i386 doesn't do this.
The md_ioctl32 definition was correct for amd64/i386 without padding,
but wrong for arm64 and powerpc64.  Make __packed__ conditional on
__amd64__, and test for the expected size on non-amd64.  Note that
mdconfig is used in the ATF test suite.  Note, I verified the
structure size for powerpc, but was unable to test.

Reviewed by:	jrtc27
Differential Revision:	https://reviews.freebsd.org/D41339
Discussed with:	jhibbits

(cherry picked from commit 58a46cfd751ac726ddca8544bf73a290b0154a57)


  Commit: 34b30dcf70055eecdfd950d4422c486822522fd6
      https://github.com/MidnightBSD/src/commit/34b30dcf70055eecdfd950d4422c486822522fd6
  Author: Eugene Grosbein <eugen at FreeBSD.org>
  Date:   2023-08-19 (Sat, 19 Aug 2023)

  Changed paths:
    M libexec/tftpd/tftpd.8
    M libexec/tftpd/tftpd.c

  Log Message:
  -----------
  tftpd: introduce new option -S

Historically, tftpd disallowed write requests to existing files
that are not publicly writable. Such requirement is questionable at least.
Let us make it possible to run tftpd in chrooted environment
keeping files non-world writable.

New option -S enables write requests to existing files
for chrooted run according to generic file permissions.
It is ignored unless tftpd runs chrooted.

Requested by:	marck
Differential:	https://reviews.freebsd.org/D41090 (based on)

(cherry picked from commit 273a307d0b80743fb08e23237b3f74dc94a8fa2a)
(cherry picked from commit 03c2616dc530e5b23f06f9aa421012154590e578)


Compare: https://github.com/MidnightBSD/src/compare/db4d5cfdc2f8...34b30dcf7005


More information about the Midnightbsd-cvs mailing list