[Midnightbsd-cvs] [MidnightBSD/src] 62002c: Fix geom build with clang 17 and KTR enabled
Zhenlei Huang
noreply at github.com
Thu Nov 23 15:23:21 EST 2023
Branch: refs/heads/master
Home: https://github.com/MidnightBSD/src
Commit: 62002cd67b82978bb17124eab7aed9f8916a72e2
https://github.com/MidnightBSD/src/commit/62002cd67b82978bb17124eab7aed9f8916a72e2
Author: Dimitry Andric <dim at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M sys/geom/geom_io.c
Log Message:
-----------
Fix geom build with clang 17 and KTR enabled
When building a kernel with clang 17 and KTR enabled, such as with the
LINT configurations, a -Werror warning is emitted:
sys/geom/geom_io.c:145:31: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand]
145 | if ((KTR_COMPILE & KTR_GEOM) && (ktr_mask & KTR_GEOM)) {
| ~~~~~~~~~~~~~~~~~~~~~~~~ ^
sys/geom/geom_io.c:145:31: note: use '&' for a bitwise operation
145 | if ((KTR_COMPILE & KTR_GEOM) && (ktr_mask & KTR_GEOM)) {
| ^~
| &
sys/geom/geom_io.c:145:31: note: remove constant to silence this warning
Replace the multiple uses of the expression with one macro, and in this
macro use "!= 0" to get a logical operand instead of a bitwise one.
Reviewed by: jhb
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D41823
(cherry picked from commit 479d224efcbf0115f8cd84314fcc46cbac146a1d)
Commit: 4b54a0b3f6603688c975c07afb9217235d51e5ae
https://github.com/MidnightBSD/src/commit/4b54a0b3f6603688c975c07afb9217235d51e5ae
Author: Zhenlei Huang <zlei at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M sys/net/if_ethersubr.c
Log Message:
-----------
net: Check per-flow priority code point for untagged traffic
Commit 868aabb4708d introduced per-flow priority. There's a defect in the
logic for untagged traffic, it does not check M_VLANTAG set in the mbuf
packet header or MTAG_8021Q/MTAG_8021Q_PCP_OUT tag set by firewall, then
can result missing desired priority in the outbound packets.
For mbuf packet with M_VLANTAG in header, some interfaces happen to work
due to bug in the drivers mentioned in D39499. As modern interfaces have
VLAN hardware offloading, the defect is barely noticeable unless the
feature per-flow priority is widely tested.
As a side effect of this defect, the soft padding to work around buggy
bridges is bypassed. That may result in regression if soft padding is
requested.
PR: 273431
Discussed with: kib
Fixes: 868aabb4708d Add IP(V6)_VLAN_PCP to set 802.1 priority per-flow
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D39536
(cherry picked from commit 49d6743da15fe378782e43776df8b4fd4f84c8d0)
(cherry picked from commit c750055382f73db964c20f8eba855a9ac9e19591)
(cherry picked from commit 8303afca1765148d0069ce5144072b3ae9cab61e)
Commit: cdf84a8c84f6c404a94aa3127007655d65c12e03
https://github.com/MidnightBSD/src/commit/cdf84a8c84f6c404a94aa3127007655d65c12e03
Author: Alan Somers <asomers at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc
M cddl/usr.sbin/zfsd/vdev_iterator.cc
Log Message:
-----------
Fix zfsd with the device_removal pool feature.
Previously zfsd would crash in the presence of a pool with a
top-level-vdev that had previously been removed. The crash happened
because the configuration nvlist of such a TLV contains an empty
ZPOOL_CONFIG_CHILDREN array, which led to a pop_front from an empty
list, which has undefined behavior.
The crash only happened in stable/14 and later, probably do to
differences in libcxx, but the change should be MFCed anyway.
PR: 273663
Reported by: Marek Zarychta <zarychtam at plan-b.pwste.edu.pl>
Sponsored by: Axcient
Reviewed by: mav
Differential Revision: https://reviews.freebsd.org/D41818
(cherry picked from commit 0b294a386d34f6584848ed52407687df7ae59861)
Commit: 97c692c5662fb588c648894109722a1c83516242
https://github.com/MidnightBSD/src/commit/97c692c5662fb588c648894109722a1c83516242
Author: Wolfram Schneider <wosch at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M usr.bin/man/man.sh
Log Message:
-----------
switch groff parameter -man to -mandoc
groff 1.23.0 changed the semantics of the -man parameter, and many
manual pages are not rendered. The -mandoc parameter brings back
the old behavior, as in groff 1.22.4 and earlier.
PR: 273565, 273245
Reviewed by: emaste, bapt
MFC after: 1 week for all supported branches (stable/12, 13, 14)
Differential Revision: https://reviews.freebsd.org/D41737
(cherry picked from commit 035f7c9a3653d91564a5513f1311aa3b6e14a17e)
Commit: 0a35130c1b5c5b9987190f26ac3c2bd14835e39f
https://github.com/MidnightBSD/src/commit/0a35130c1b5c5b9987190f26ac3c2bd14835e39f
Author: Wolfram Schneider <wosch at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M usr.bin/man/man.conf.5
Log Message:
-----------
switch groff parameter -man to -mandoc for new groff release 1.23.0
PR: 273565
(cherry picked from commit cd89fe3923e92ab090cbdff7eb215c2d85b51718)
Commit: 500aa74a9aefa3dc2e7ebfd02591f2aebc5756da
https://github.com/MidnightBSD/src/commit/500aa74a9aefa3dc2e7ebfd02591f2aebc5756da
Author: John Hein <jcfyecrayz at liamekaens.com>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M lib/libprocstat/core.c
Log Message:
-----------
libprocstat: use elf_getphdrnum rather than deprecated elf_getphnum
PR: 273966
Reviewed by: emaste
(cherry picked from commit 633094c27f0ac1b1001d5bd24a883240b4bce1dc)
(cherry picked from commit fd8bf2ecc05af841aa7e8369a43861cdc122d404)
Commit: f05ec2ed5eeae6dab2e3c4d05ac68d48ce020f93
https://github.com/MidnightBSD/src/commit/f05ec2ed5eeae6dab2e3c4d05ac68d48ce020f93
Author: Cy Schubert <cy at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M sys/netpfil/ipfilter/netinet/fil.c
Log Message:
-----------
ipfilter: Avoid allocating a new ipf token when not needed
Only allocate a new ipftoken_t if one cannot be found. This eliminates
allocating unnecessary token structures that will never be used when
performing simple lookups for existing token structures.
(cherry picked from commit 7f5e3b9fa3d159b7f061b4d01a767cbe5d0527f3)
Commit: 658a8ab6864ede624109aeb2e6b2a40809184bab
https://github.com/MidnightBSD/src/commit/658a8ab6864ede624109aeb2e6b2a40809184bab
Author: Zhenlei Huang <zlei at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M sys/net/rtsock.c
Log Message:
-----------
rtsock: Add sysctl flag CTLFLAG_TUN to loader tunable
The sysctl variable `net.route.netisr_maxqlen` is actually a loader
tunable. Add sysctl flag CTLFLAG_TUN to it so that `sysctl -T` will
report it correctly.
No functional change intended.
Reviewed by: glebius
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D41928
(cherry picked from commit 21a722d9593eb477f4ccdad011a2b4df0727fc62)
(cherry picked from commit bffb01eda9bffc3307ea8bf70f91087ed316e01c)
(cherry picked from commit c6afda2e5a0389ce293d3a3ced2889979aa2e442)
Commit: 30885858af8f4b270e08a59a7546bc2c2d6a80ee
https://github.com/MidnightBSD/src/commit/30885858af8f4b270e08a59a7546bc2c2d6a80ee
Author: Zhenlei Huang <zlei at FreeBSD.org>
Date: 2023-11-23 (Thu, 23 Nov 2023)
Changed paths:
M sys/netinet6/in6_proto.c
Log Message:
-----------
netinet6: Add sysctl flag CTLFLAG_TUN to loader tunables
The following sysctl variables are actually loader tunables. Add sysctl
flag CTLFLAG_TUN to them so that `sysctl -T` will report them correctly.
1. net.inet6.ip6.auto_linklocal
2. net.inet6.ip6.accept_rtadv
3. net.inet6.ip6.no_radr
No functional change intended.
Reviewed by: glebius
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D41928
(cherry picked from commit 03dac3e37993801dab4418087bfedacce0526e66)
(cherry picked from commit da2b630c12ec074673dfc646b2055a31b0d8d6d9)
(cherry picked from commit 28a80239fd6ab2ff79af5a2b19e349fa6f1d62e9)
Compare: https://github.com/MidnightBSD/src/compare/496a9ca51e1f...30885858af8f
More information about the Midnightbsd-cvs
mailing list