[Midnightbsd-cvs] [MidnightBSD/src] 80bb25: nfscl: Fix processing of a rare Rename reply case

[Lucas Holt]

  Branch: refs/heads/stable/3.1
  Home:   https://github.com/MidnightBSD/src
  Commit: 80bb251d04a12cfbe91b63ee8b1f6043d9b0a497
      https://github.com/MidnightBSD/src/commit/80bb251d04a12cfbe91b63ee8b1f6043d9b0a497
  Author: Rick Macklem <rmacklem at FreeBSD.org>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M sys/fs/nfsclient/nfs_clrpcops.c

  Log Message:
  -----------
  nfscl: Fix processing of a rare Rename reply case

When delegations are enabled (they are not by default in
the FreeBSD NFSv4 server), rename will check for and return
delegations.  If the second of these DelegReturn operations
were to fail (they rarely do), then the code would not retry
the rename with returning delegations, as it is intended to do.

The patch fixes the problem, since the DelegReturn reply status
is the second iteration of the loop and not the first iteration.

As noted, this bug would have rarely manifested a problem, since
DelegReturn operations do not normally fail.

(cherry picked from commit 6aded1e6b2e5549120031032e1c7f8b002882327)


  Commit: 35dbe2d1f3e37364f5748bf5ac7eb1e6c7d75bb1
      https://github.com/MidnightBSD/src/commit/35dbe2d1f3e37364f5748bf5ac7eb1e6c7d75bb1
  Author: Rick Macklem <rmacklem at FreeBSD.org>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M sys/fs/nfsclient/nfs_clrpcops.c

  Log Message:
  -----------
  nfscl: Fix comment for commit 6aded1e6b2e5

Commit 6aded1e6b2e5 fixed a rare case when handling an NFSv4
Rename reply when delegations are in use.  This patch fixes the
associated comment.

(cherry picked from commit 0a958aa16fed1978879d64e3b225f1d232cc5a98)


Compare: https://github.com/MidnightBSD/src/compare/0a1f96bffd35...35dbe2d1f3e3