[Midnightbsd-cvs] [MidnightBSD/src] 84571e: Fix snprintf truncation in telnet

Dimitry Andric noreply at github.com
Tue Jan 9 17:24:07 EST 2024


  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/src
  Commit: 84571ee95099b5a1dc58f9af75d5a11915f566f1
      https://github.com/MidnightBSD/src/commit/84571ee95099b5a1dc58f9af75d5a11915f566f1
  Author: Dimitry Andric <dim at FreeBSD.org>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    M contrib/telnet/telnet/telnet.c

  Log Message:
  -----------
  Fix snprintf truncation in telnet

Building telnet with clang 18 results in the following warning:

  contrib/telnet/telnet/telnet.c:231:5: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 11 [-Werror,-Wformat-truncation]
    231 |     snprintf(temp2, sizeof(temp2), "%c%c%c%c....%c%c", IAC, SB, TELOPT_COMPORT,
	|     ^

The temp2 buffer is 10 chars, while the format string also consists of
10 chars. Therefore, snprintf(3) will truncate the last character, 'SE'
(end sub negotation) in this case.

Bump the buffer to 11 chars to avoid truncation.

MFC after:	3 days

(cherry picked from commit c794d188222a4d3414233ff9630d47eedc090fbe)




More information about the Midnightbsd-cvs mailing list