[Midnightbsd-cvs] [MidnightBSD/src] 750548: src.conf: Add a MK_ZFS_TESTS knob
Jessica Clarke
noreply at github.com
Sun Jan 18 15:36:38 EST 2026
Branch: refs/heads/master
Home: https://github.com/MidnightBSD/src
Commit: 750548898f8fff63fcc808c34ac80ea6b289297a
https://github.com/MidnightBSD/src/commit/750548898f8fff63fcc808c34ac80ea6b289297a
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M share/mk/src.opts.mk
M tests/sys/cddl/Makefile
Log Message:
-----------
src.conf: Add a MK_ZFS_TESTS knob
The in-tree ZFS test suite is somewhat outdated and I see a number of
failures there. I tend to think that we want to integrate the OpenZFS
test suite somehow, replacing the legacy one, though it's also possible
to run that as a separate test suite.
In any case, if one wants to run the OpenZFS test suite separately, it's
useful to be able to disable installation of the legacy ZFS test suite,
so let's provide a src.conf option to do that.
Reviewed by: asomers
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D46476
(cherry picked from commit 24affded3d4ec5fafb6b22f773ec1e20d73b9b03)
Commit: ac9e7f433ca356c760e015654e5b9026cd4bfee0
https://github.com/MidnightBSD/src/commit/ac9e7f433ca356c760e015654e5b9026cd4bfee0
Author: Konstantin Belousov <kib at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/fs/nullfs/null_vnops.c
Log Message:
-----------
nullfs lookup: cn_flags is 64bit
Reviewed by: olce
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D50390
(cherry picked from commit 89549c2348170921cc4270ac95bfabfd78d42739)
Commit: 3989a84ca24577a5e9a4a1466d5201050a708943
https://github.com/MidnightBSD/src/commit/3989a84ca24577a5e9a4a1466d5201050a708943
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/fs/nullfs/null_vnops.c
M sys/fs/unionfs/union_vnops.c
M sys/kern/vfs_cache.c
M sys/kern/vfs_lookup.c
M sys/sys/namei.h
Log Message:
-----------
namei: Make stackable filesystems check harder for jail roots
Suppose a process has its cwd pointing to a nullfs directory, where the
lower directory is also visible in the jail's filesystem namespace.
Suppose that the lower directory vnode is moved out from under the
nullfs mount. The nullfs vnode still shadows the lower vnode, and
dotdot lookups relative to that directory will instantiate new nullfs
vnodes outside of the nullfs mountpoint, effectively shadowing the lower
filesystem.
This phenomenon can be abused to escape a chroot, since the nullfs
vnodes instantiated by these dotdot lookups defeat the root vnode check
in vfs_lookup(), which uses vnode pointer equality to test for the
process root.
Fix this by extending nullfs and unionfs to perform the same check,
exploiting the fact that the passed componentname is embedded in a
nameidata structure to avoid changing the VOP_LOOKUP interface. That
is, add a flag to indicate that containerof can be used to get the full
nameidata structure, and perform the root vnode check on the lower vnode
when performing a dotdot lookup.
PR: 262180
Reviewed by: olce, kib
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D50418
(cherry picked from commit 7587f6d4840f8d363e457cddc14c184cf1fe7cc1)
Commit: 70a84e6292e1216e3d129426ac9378c580431c1c
https://github.com/MidnightBSD/src/commit/70a84e6292e1216e3d129426ac9378c580431c1c
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/kern/vfs_vnops.c
Log Message:
-----------
vfs: Don't clobber namei flags in vn_open_cred()
Otherwise NAMEILOOKUP is cleared. More generally it seems quite
surprising that the flags set by vn_open_cred() callers are not
automatically preserved. Modify open2nameif() such that it takes
already-set namei flags into account.
Reviewed by: olce, kib
Fixes: 7587f6d4840f ("namei: Make stackable filesystems check harder for jail roots")
Differential Revision: https://reviews.freebsd.org/D50531
(cherry picked from commit e05e33041c252dc236939683c01ca4b7b083562c)
Commit: cf79fb2443b74f17dabbde863d296ff0295333f2
https://github.com/MidnightBSD/src/commit/cf79fb2443b74f17dabbde863d296ff0295333f2
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/kern/vfs_cache.c
Log Message:
-----------
namei: Remove a now-unused variable
Reported by: bapt
Fixes: 7587f6d4840f ("namei: Make stackable filesystems check harder for jail roots")
(cherry picked from commit 14ec281a09d7818def2083ef0c3e28f8101f4268)
Commit: 222072223e75235cb84b61a4624635a434841f7b
https://github.com/MidnightBSD/src/commit/222072223e75235cb84b61a4624635a434841f7b
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/kern/vfs_cache.c
Log Message:
-----------
vfs cache: Add NAMEILOOKUP to the whitelist of fastpath lookup flags
Otherwise the lockless name lookup path is inadvertently disabled since
NAMEILOOKUP isn't recognized.
Reviewed by: olce, kib
Fixes: 7587f6d4840f ("namei: Make stackable filesystems check harder for jail roots")
Differential Revision: https://reviews.freebsd.org/D50532
(cherry picked from commit f4158953007f557061d91f99d2374d48d8376cc6)
Commit: cb964c18783cfb24cfb3eddcd626d140f55ff170
https://github.com/MidnightBSD/src/commit/cb964c18783cfb24cfb3eddcd626d140f55ff170
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/fs/cd9660/cd9660_lookup.c
M sys/fs/fuse/fuse_vnops.c
M sys/fs/smbfs/smbfs_vnops.c
M sys/fs/unionfs/union_vnops.c
M sys/kern/uipc_mqueue.c
M sys/kern/vfs_cache.c
Log Message:
-----------
namei: Fix cn_flags width in various places
This truncation is mostly harmless today, but fix it anyway to avoid
pain later down the road.
Reviewed by: olce, kib
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D50417
(cherry picked from commit 0d224af399a66f00a5b33e5512fc018062cabf1d)
Commit: ad630cacf619ddfc259ca8b131a691fe50584f77
https://github.com/MidnightBSD/src/commit/ad630cacf619ddfc259ca8b131a691fe50584f77
Author: Dimitry Andric <dim at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.h
M lib/clang/midnightbsd_cc_version.h
M lib/libgcc_s/Makefile
Log Message:
-----------
Reapply "Merge commit e24f90190c77 from llvm git (by Brad Smith):"
[Driver] Enable outline atomics for FreeBSD/aarch64 (#156089)
The compiler_rt helper functions have been built since 12.4, 13.1, 14
and anything newer.
This reverts commit bd27bd1f51d049538cc7a0053be9d99110a53ae1.
Only some people (including the release manager, unfortunately) ran into
build issues with the previous iteration of this commit, because they
were bootstrapping the compiler, either via the WITHOUT_SYSTEM_COMPILER
src.conf(5) setting, or because the build system determined that their
base system compiler was out of date.
The bootstrapped compiler would then enable outline atomics and compile
libgcc_s with these, but because libgcc_s is linked with -nodefaultlibs,
it could not find the helper routines in libcompiler_rt.a.
In contrast, people who did not bootstrap the compiler never saw any
issues, because libgcc_s was built using their 'old' base system
compiler, and so libgcc_s would not contain any calls to those helper
routines.
Fix this by ensuring that libgcc_s is linked against libcompiler_rt.a
explicitly, similar to some other binaries and libraries that are built
with -nodefaultlibs.
Also, bump FREEBSD_CC_VERSION to ensure that everybody gets the updated
compiler with outline atomics enabled. (This should have been done in
the first iteration of this commit, because the error would have shown
up right away then.)
MFC after: 3 days
(cherry picked from commit 3289bace53f31545976fec310b41fa784de75e64)
Commit: 64e79ce815fba67c2fb1bf307d0ccbb7bee49792
https://github.com/MidnightBSD/src/commit/64e79ce815fba67c2fb1bf307d0ccbb7bee49792
Author: Jose Luis Duran <jlduran at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M usr.bin/beep/beep.1
M usr.bin/beep/beep.c
Log Message:
-----------
beep: Sort usage and man page options
Sort usage and man page options, mention possible minimum and maximum
values, fix punctuation marks, and cleanup the man page.
PR: 291092
Reviewed by: pauamma_gundo.com, christos
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53827
(cherry picked from commit 55d98b024f25403f60efe04f90a391014b6bc388)
Commit: 074bd2835836d0fc434163d4b6c3a1982e0c52ae
https://github.com/MidnightBSD/src/commit/074bd2835836d0fc434163d4b6c3a1982e0c52ae
Author: Kristof Provost <kp at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/netpfil/pf/pf.c
Log Message:
-----------
pf: handle divert packets
In a divert setup pf_test_state() may return PF_PASS, but not set the state
pointer. We didn't handle that, and as a result crashed immediately afterwards
trying to dereference that NULL state pointer.
Add a test case to provoke the problem.
PR: 260867
MFC after: 2 weeks
Submitted by: Phil Budne <phil.budne at gmail.com>
Sponsored by: Rubicon Communications, LLC ("Netgate")
(cherry picked from commit 66f2f1c83247f05a3a599d7e88c7e7efbedd16b5)
Commit: 6f1686d7b691cf6ffd2d9588307f78f037b9fbfc
https://github.com/MidnightBSD/src/commit/6f1686d7b691cf6ffd2d9588307f78f037b9fbfc
Author: Dimitry Andric <dim at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/clang/libllvm/Makefile
Log Message:
-----------
Remove TableGen objects from libllvm, fixing bad option registrations
In 986e05bc2a18 I revamped the build for all the llvm subprojects. Among
others I added objects under contrib/llvm-project/llvm/lib/TableGen, but
I missed that upstream explicitly removes these when building the shared
llvm library:
https://github.com/llvm/llvm-project/blob/llvmorg-19.1.7/llvm/tools/llvm-shlib/CMakeLists.txt#L23
In 2e47f35be5dc I converted libllvm to a shared library. From that point
onwards, some of the global command line option objects registered in
llvm/lib/TableGen/Main.cpp conflict with similar objects in tools like
llvm-cov, llvm-as, etc.
This results in an error when running these tools: "CommandLine Error:
Option 'o' registered more than once!", followed by a fatal exit.
Fix this by removing the TableGen objects from libllvm. Note that we no
longer install any of the tblgen binaries, these are only used during
buildworld, and then in a statically linked form.
PR: 291233
MFC after: 3 days
(cherry picked from commit 9978553d0199e7ec0bdd1c44fc7f6c7b0c11e43b)
Commit: e03a6b37dd3220f08e20618df058b18bded589c8
https://github.com/MidnightBSD/src/commit/e03a6b37dd3220f08e20618df058b18bded589c8
Author: Cy Schubert <cy at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M libexec/rc/rc.d/ippool
Log Message:
-----------
ipfilter: Load optionlist prior to ippool invocation
As a safety precaution df381bec2d2b limits ippool hash table size to 1K.
This causes any legitimely large hash table to fail to load. The
htable_size_max ipf tuneable adjusts this but the adjustment is made
in the ipfilter rc script, invoked after the ippool script (because it
depends on ippool). Let's load the ipfilter_optionlist in ippool as well.
ipfilter_optionlist load will also occur in the ipfilter rc script in case
the user uses ipfilter without ippool.
Fixes: df381bec2d2b
(cherry picked from commit d5d005e9bf4933d5680dd0bb5d42bdf440122aa4)
Commit: b89143a8cc75a09745a78a50b3918c58b72f0ff2
https://github.com/MidnightBSD/src/commit/b89143a8cc75a09745a78a50b3918c58b72f0ff2
Author: Jose Luis Duran <jlduran at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/libc/stdlib/strfmon.c
Log Message:
-----------
strfmon: Fix typo s/poistion/position/
MFC after: 1 week
(cherry picked from commit 91e7f19ec4056587a85c1461a4f34a6d5d4b7b52)
Commit: b8112d8d3fd443e526d2e97dfb67e594d11f1c0b
https://github.com/MidnightBSD/src/commit/b8112d8d3fd443e526d2e97dfb67e594d11f1c0b
Author: Jose Luis Duran <jlduran at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/libc/tests/stdlib/strfmon_test.c
Log Message:
-----------
strfmon: Add tests for Austin Group Defect 1199
Add tests for The Open Group Base Specifications Issue 8[1], Austin
Group Defect 1199[2].
Items marked with XXX represent an invalid output. These items will be
fixed in subsequent commits.
Notice that an existing test is now considered invalid.
Our locale definitions do not include int_p_sep_by_space nor
int_n_sep_by_space[3]. Those will be addressed in a subsequent commit.
However, the CLDR project defines them as "0", which causes the output
to appear as "USD123.45". If our locale definitions were to set the
international {n,p}_sep_by_space to "1", the output would display as the
expected "USD 123.45".
While here, use the SPDX license identifier and add my name to the
file.
[1]: https://pubs.opengroup.org/onlinepubs/9799919799/functions/strfmon.html
[2]: https://www.austingroupbugs.net/view.php?id=1199
[3]: https://unicode-org.atlassian.net/browse/CLDR-237
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53911
(cherry picked from commit 19e153004fb63c32eba0ef40249f5ede61a93170)
Commit: fdb4ef2b7b79cef3a7bf2d76712ed9518e0e220d
https://github.com/MidnightBSD/src/commit/fdb4ef2b7b79cef3a7bf2d76712ed9518e0e220d
Author: Jose Luis Duran <jlduran at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/libc/stdlib/strfmon.3
M lib/libc/stdlib/strfmon.c
M lib/libc/tests/stdlib/strfmon_test.c
Log Message:
-----------
strfmon: EINVAL if the '+' flag and both signs are empty
According to the Open Group Base Specifications Issue 8[1], strfmon(3)
should return EINVAL when the '+' flag was included in a conversion
specification and the locale's positive_sign and negative_sign values
would both be returned by localeconv(3) as empty strings.
Austin Group Defect 1199[2] is applied, adding the [EINVAL] error.
[1]: https://pubs.opengroup.org/onlinepubs/9799919799/functions/strfmon.html
[2]: https://www.austingroupbugs.net/view.php?id=1199
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53912
(cherry picked from commit 1fd018972a18b682521bb8f004dfd162327e5db2)
Commit: 48e21c08f9f506d80ef7f3fe10a4ef1d52d4f9ec
https://github.com/MidnightBSD/src/commit/48e21c08f9f506d80ef7f3fe10a4ef1d52d4f9ec
Author: Jose Luis Duran <jlduran at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/libc/stdlib/strfmon.c
M lib/libc/tests/stdlib/strfmon_test.c
Log Message:
-----------
strfmon: Fix negative sign handling for C locale
If the locale's positive_sign and negative_sign values would both be
returned by localeconv() as empty strings, strfmon() shall behave as if
the negative_sign value was the string "-".
This occurs with the C locale. The implementation previously assigned
"0" to sign_posn (parentheses around the entire string); now it assigns
it to "1" (sign before the string) when it is undefined (CHAR_MAX).
Austin Group Defect 1199[1] is applied, changing the requirements for
the '+' and '(' flags.
[1]: https://www.austingroupbugs.net/view.php?id=1199
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53913
(cherry picked from commit cf85e7034ad5640b18a3b68d6b291b7bf89bfc80)
Commit: 803dc632fcd13ce648717dcba017131d7ba89743
https://github.com/MidnightBSD/src/commit/803dc632fcd13ce648717dcba017131d7ba89743
Author: Dag-Erling Smørgrav <des at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M libexec/rtld-elf/rtld.c
Log Message:
-----------
rtld-elf: Mark LD_SHOW_AUXV insecure
This prevents dumping the memory layout of setugid processes.
MFC after: 3 days
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D54033
(cherry picked from commit 5242bcff202fa2a5a39895423c8d8c11c02ad76a)
Commit: cf7f8c4b7ad0f94fefa3b1e33394714efc0031e2
https://github.com/MidnightBSD/src/commit/cf7f8c4b7ad0f94fefa3b1e33394714efc0031e2
Author: Kristof Provost <kp at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/netpfil/pf/if_pfsync.c
Log Message:
-----------
pfsync: fix incorrect unlock during destroy
During pfsync_clone_destroy() we clean up pending packets. This
may involve calling pfsync_undefer() or callout_drain(). We may not
hold the bucket lock during callout_drain(), but must hold it during
pfsync_undefer().
We incorrectly always released the lock, leading to assertion failures
during cleanup if there were pending deferred packets.
MFC after: 1 week
Sponsored by: Orange Business Services
(cherry picked from commit 639e65144aa71cb03b5431861803f528308760dc)
Commit: e2da73d621bf393f6a5805ba9bda9ef3ad03ad56
https://github.com/MidnightBSD/src/commit/e2da73d621bf393f6a5805ba9bda9ef3ad03ad56
Author: Cy Schubert <cy at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M libexec/rc/rc.d/ipfilter
M libexec/rc/rc.d/ippool
Log Message:
-----------
rc.d/{ipfilter,ippool}: Fix typo in variable name
(cherry picked from commit f04b23ce3547c238dcd52d4fa1a7d401ad38d1b1)
Commit: 9011e1041bb2f8aa521357030502477b8d365a65
https://github.com/MidnightBSD/src/commit/9011e1041bb2f8aa521357030502477b8d365a65
Author: Cy Schubert <cy at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M libexec/rc/rc.d/ipfilter
Log Message:
-----------
rc.d/ipfilter: ipfilter must be enabled for options to take
ipfilter options are erased and reset to default when ipfilter is
disabled. This results in nullifying options from rc.conf that were
previously set.
8d6feaaaa26f, which added this code, was incorrect as it was for a bug in
ipfilter 4.2.28 and no longer applies to ipfilter 5.1.2.
Fixes: 8d6feaaaa26f
(cherry picked from commit cc1e4aae5a67a20f3c0fff13612364e6e4404f93)
Commit: 3425ec41207cf78c3b4b7259f55be51482418e78
https://github.com/MidnightBSD/src/commit/3425ec41207cf78c3b4b7259f55be51482418e78
Author: Kristof Provost <kp at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/netpfil/pf/pf.c
M tests/sys/netpfil/pf/sctp.py
Log Message:
-----------
pf: relax sctp v_tag verification
pf was too strict when validating SCTP tags. When a server receives a
retransmitted INIT it will reply with a random initiate tag every time.
However, pf saves the first initiate tag and expects every subsequent INIT_ACK
retransmission to have the same tag. This is not the case, leading to endless
INIT/INIT_ACK cycles.
Allow the tag to be updated as long as we've not gone past COOKIE_WAIT.
Add a test case to verify this.
MFC after: 2 weeks
See also: https://redmine.pfsense.org/issues/16516
Sponsored by: Rubicon Communications, LLC ("Netgate")
(cherry picked from commit bc3b72ff48953551e0e8bd6e5a2c718ecd973285)
Commit: 7affc72144595e496a246ad0d5c9ba0ff8e4a649
https://github.com/MidnightBSD/src/commit/7affc72144595e496a246ad0d5c9ba0ff8e4a649
Author: Dag-Erling Smørgrav <des at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/sys/bus.h
Log Message:
-----------
bus: Return 0 if reading an ivar fails
In the non-INVARIANTS case, return 0 rather than stack garbage if
reading an ivar fails (in the INVARIANTS case, we still panic).
MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.
Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D54078
(cherry picked from commit 4c2295c15860e70c8bd3f05f9229d2fc40dfd50d)
Commit: 5102b31578f49fb8cf22575319fa0a628d807dec
https://github.com/MidnightBSD/src/commit/5102b31578f49fb8cf22575319fa0a628d807dec
Author: Mark Johnston <markj at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/dev/netmap/netmap_freebsd.c
Log Message:
-----------
netmap: Fix error handling in nm_os_extmem_create()
We bump the object reference count prior to mapping it into the kernel
map, at which point the vm_map_entry owns the reference. Then, if
vm_map_wire() fails, vm_map_remove() will release the reference, so we
should avoid decrementing it in the error path.
Reported by: Ilja van Sprundel <ivansprundel at ioactive.com>
Reviewed by: vmaffione
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53066
(cherry picked from commit dfc1041c08ba32f24b8050b4d635a0bbbfd9b767)
Commit: dfc902c875ad781f5216e3c6c19cc5e429fb8950
https://github.com/MidnightBSD/src/commit/dfc902c875ad781f5216e3c6c19cc5e429fb8950
Author: Mateusz Piotrowski <0mp at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/kern/vfs_cache.c
Log Message:
-----------
vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done
1. The definition lists struct nameidata as the type of the first
argument. However, the actual probes always pass a variable of type
struct nameidata* to SDT_PROBE3.
2. The third argument (args[2]) is actually enum cache_fpl_status.
Reviewed by: markj
Approved by: markj (mentor)
Fixes: 07d2145a1717 vfs: add the infrastructure for lockless lookup
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D51315
(cherry picked from commit 6567623f831daaffa67777d17780e8f424c1bb01)
Commit: 54d842bb479c8d72dcb19bb6c764c0050d5f942b
https://github.com/MidnightBSD/src/commit/54d842bb479c8d72dcb19bb6c764c0050d5f942b
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M share/mk/bsd.subdir.mk
Log Message:
-----------
bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation
Not all of the tree is happy for realinstall to be done in parallel. In
particular, Makefile.inc1 uses .WAIT to force etc to be installed after
earlier subdirectories, since etc calls into share/man's makedb to run
makewhatis on the tree and needs all manpages to have been installed.
Also, libexec/Makefile doesn't set SUBDIR_PARALLEL, and the link from
ld-elf32.1 to ld-elf.1 relies on rtld-elf having been installed before
rtld-elf32, otherwise creating the link will fail.
In general, core behavioural differences like this between NO_ROOT and
"normal" builds are also dangerous and confusing.
If this optimisation is deemed important, it should be reintroduced in a
more limited and robust manner that doesn't break the above situations.
Until then value correctness over slight efficiency gains on high core
count machines, the same machines where you're more likely to encounter
issues from this optimisation.
This reverts commits cd19ecdbdc87 ("Similar to r296013 for NO_ROOT,
force SUBDIR_PARALLEL for buildworld WORLDTMP staging.") and
b9c6f3168112 ("Add more STANDALONE_SUBDIR_TARGETS.").
Found by: CheriBSD Jenkins
Reviewed by: bdrewery, brooks
Fixes: cd19ecdbdc87 ("Similar to r296013 for NO_ROOT, force SUBDIR_PARALLEL for buildworld WORLDTMP staging.")
Fixes: b9c6f3168112 ("Add more STANDALONE_SUBDIR_TARGETS.")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D43705
(cherry picked from commit fbae308319b7678cd9d879f60b1efd8d4c99b5eb)
Commit: 257ae19f5afc85cfff997f9d00672834a23d92ff
https://github.com/MidnightBSD/src/commit/257ae19f5afc85cfff997f9d00672834a23d92ff
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M usr.sbin/bsdinstall/scripts/netconfig
Log Message:
-----------
bsdinstall: Fix netconfig script when no interfaces are present
The script uses [ -z "$INTERFACES" ] to check if the list of interfaces
is empty and will exit early if so, but INTERFACES always contains at
least a space due to the way it appends the list of wireless devices.
Fix this by only adding the space when there are devices to append,
mirroring the behaviour for non-wireless devices above (both will result
in a redundant leading space when the list is non-empty, but that one is
harmless).
Fixes: 159ca5c844cd ("Adapt to new wireless scheme where base wlan interfaces do not show up in ifconfig anymore.")
MFC after: 1 week
(cherry picked from commit b809c7d6a26924ac351e49a15011da718cc3feec)
Commit: e5dcd4f377fe632be1d04d992b07b960b952952b
https://github.com/MidnightBSD/src/commit/e5dcd4f377fe632be1d04d992b07b960b952952b
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M usr.sbin/bsdinstall/scripts/netconfig
Log Message:
-----------
bsdinstall: Drop Error from title in netconfig no interfaces dialog
This isn't inherently an error. It is if you're attempting to download
dist tarballs or later install packages, but a FreeBSD system with no
NIC is a reasonable setup to have, especially in a throwaway VM setting,
so we shouldn't say it is one.
Leaving the exit code as 1 is still fine, since auto will ignore it, and
avoids breaking other uses.
MFC after: 1 week
(cherry picked from commit 7414d14bd51d8378057bbe952c2715b9f32d1d3e)
Commit: 7da389c9f7bc3ef0462c324d9e84dc465c584987
https://github.com/MidnightBSD/src/commit/7da389c9f7bc3ef0462c324d9e84dc465c584987
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M contrib/ee/ee.c
Log Message:
-----------
ee: Fix use of uninitialised pointer in ispell_op
This used to be name = mktemp followed by fd = open downstream,
replacing upstream's crude PID-based sprintf, but in 1.4.7 this was
changed upstream to this buggy code, which we then picked up in the
1.5.0 import. Presumably nobody's actually used ee's ispell function
in the past 15 years; that or it's just ended up using junk file names
as temporary files if name's happened to be a valid address to something
that can be interpreted as a string.
Reported by: Dapeng Gao <dapeng.gao at cl.cam.ac.uk>
Fixes: 96b676e99984 ("Update ee(1) in the base system to version 1.5.0.")
MFC after: 1 week
(cherry picked from commit 25a33bfe9ce2b55812201f475e9d3e64009b40dc)
Commit: a25c895fe67cd4ae9adc4a66d55e81f3742159f7
https://github.com/MidnightBSD/src/commit/a25c895fe67cd4ae9adc4a66d55e81f3742159f7
Author: Dapeng Gao <dg612 at cam.ac.uk>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M usr.sbin/bluetooth/btpand/btpand.c
Log Message:
-----------
Fix off-by-one bug in btpand
`ul` reaches `__arraycount(services)` before the bound-check happens, causing undefined behaviour.
Reviewed by: imp, jrtc27
Fixes: 7718ced0ea98 ("Add btpand(8) daemon from NetBSD.")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D45463
(cherry picked from commit fbfdf57d65bedfab28f9debc8a4a8d6802f9338a)
Commit: 420a0114a872b3daa8ea7dbed0ff2fef66c67c76
https://github.com/MidnightBSD/src/commit/420a0114a872b3daa8ea7dbed0ff2fef66c67c76
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M libexec/rtld-elf/aarch64/reloc.c
M libexec/rtld-elf/amd64/reloc.c
M libexec/rtld-elf/arm/reloc.c
M libexec/rtld-elf/i386/reloc.c
M libexec/rtld-elf/mips/reloc.c
M libexec/rtld-elf/powerpc/reloc.c
M libexec/rtld-elf/powerpc64/reloc.c
M libexec/rtld-elf/riscv/reloc.c
M libexec/rtld-elf/rtld.c
M libexec/rtld-elf/rtld.h
Log Message:
-----------
rtld-elf: Pass parsed aux_info to ifunc_init
Currently we pass the raw pointer to the on-stack auxargs. This can
legitimately have fewer than AT_COUNT entries, so the use of
__min_size(AT_COUNT), i.e. static AT_COUNT, is inaccurate, and also
needlessly forces the callee to iterate over the elements to find the
entry for a given type. Instead we can just pass aux_info like we use
for everything else.
Note that the argument has been left unused by every callee since its
introduction in 4352999e0e6c ("Pass CPUID[1] %edx (cpu_feature), %ecx
(cpu_feature2) and CPUID[7].%ebx (cpu_stdext_feature), %ecx
(cpu_stdext_feature2) to the ifunc resolvers on x86.")
Reviewed by: kib
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D46276
(cherry picked from commit 33658afd4e4d11cd71d92e52ca9da5381cdd829b)
Commit: 987392eccfe1678cae70c68e60228ea1cd313975
https://github.com/MidnightBSD/src/commit/987392eccfe1678cae70c68e60228ea1cd313975
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M libexec/rtld-elf/riscv/reloc.c
M libexec/rtld-elf/riscv/rtld_machdep.h
Log Message:
-----------
rtld-elf: Support IFUNCs on riscv
GNU/Linux has historically had the following two resolver prototypes:
1. Elf_Addr(uint64_t, void *)
2. Elf_Addr(uint64_t, void *, void *)
For the former, AT_HWCAP is passed in the first argument, and NULL in
the second. For the latter, AT_HWCAP is still passed, and the second
argument is a pointer to their home-grown __riscv_hwprobe function.
Should they want to use the third argument in future, they'll have to
introduce yet another prototype to allow for later expansion, and then
all users will have to check whether the second argument is NULL to know
if the third argument really exists. This is all rather silly and will
surely prove fun in the face of type-checking CFI.
Instead, be like arm64 and just define all 8 possible general purpose
register arguments up front. To naive source code that forgets non-Linux
OSes exist this will be compatible with prototype 1 above, since the
second argument will be 0 and it won't look further (though should we
start using the second argument for something that wouldn't be true any
more and it might think it's __riscv_hwprobe, but that incompatibility
is one we can defer committing to, and can choose to never adopt).
Until the standard interface for querying extension information[1] is
settled and implemented in FreeBSD there's not much you can do in a
resolver other than use HWCAP_ISA_B, but this gets the infrastructure in
place for when that day comes.
[1] https://github.com/riscv-non-isa/riscv-c-api-doc/pull/74
Reviewed by: kib, mhorne
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D46278
(cherry picked from commit 729d2b16b74fa5207a12aa1de190bd930432810e)
Commit: 06e6a0182ae8e727408edc9e6c262227d325e7c0
https://github.com/MidnightBSD/src/commit/06e6a0182ae8e727408edc9e6c262227d325e7c0
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/geom/part/gpart.8
M sys/geom/part/g_part.c
M sys/geom/part/g_part.h
M sys/geom/part/g_part_gpt.c
M sys/sys/disk/gpt.h
Log Message:
-----------
gpart: Add u-boot-env alias for U-Boot's environment GPT partition UUID
This is a platform-independent UUID, and this is the name U-Boot uses.
MFC after: 1 week
(cherry picked from commit b162fc3f3094c50c8ed47ab50981c5448cf0052c)
Commit: 8e2eb38b614388e8d8d10c05dc4e84aa2fb343d0
https://github.com/MidnightBSD/src/commit/8e2eb38b614388e8d8d10c05dc4e84aa2fb343d0
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M sys/contrib/openzfs/lib/libspl/include/sys/types32.h
Log Message:
-----------
Merge commit 88433e640ddb from upstream OpenZFS (by Jessica Clarke)
sys/types32.h: Remove struct timeval32 from libspl's header (#16491)
macOS Sequoia's sys/sockio.h, as included by various bootstrap tools
whilst building FreeBSD, has started to include net/if.h, which then
includes sys/_types/_timeval32.h and provide a conflicting definition
for struct timeval32. Since this type is entirely unused within OpenZFS,
simply delete the type rather than adding in some kind of OS detection.
This fixes building FreeBSD on macOS Sequoia (Beta).
Signed-off-by: Jessica Clarke <jrtc27 at jrtc27.com>
Reviewed-by: Rob Norris <rob.norris at klarasystems.com>
Reviewed-by: Alexander Motin <mav at FreeBSD.org>
Reviewed-by: Tony Hutter <hutter2 at llnl.gov>
MFC after: 1 week
(cherry picked from commit 796c6031cde6dfdd92b4d178792fc0534bf788c5)
Commit: 3eb32a3462bad53132e0ed2edc68197adf341b33
https://github.com/MidnightBSD/src/commit/3eb32a3462bad53132e0ed2edc68197adf341b33
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M lib/clang/llvm.build.mk
Log Message:
-----------
lib/clang: Commit cleaned-up workaround for building on RISC-V
There is a long-standing issue on RISC-V around --gc-sections when
statically linking, which affects the bootstrap build of LLVM. Since
fixing this properly has remained a TODO for years, commit the
workaround with documentation so that building natively from source
works out of the box.
PR: 258358
MFC after: 1 week
(cherry picked from commit 7aa6667623bef7306009d50a571e5e8c7766a174)
Commit: 91cb03381c895d1149cd98e756c87a6c571b32ae
https://github.com/MidnightBSD/src/commit/91cb03381c895d1149cd98e756c87a6c571b32ae
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M tools/build/depend-cleanup.sh
Log Message:
-----------
depend-cleanup.sh: Clean up after riscv static binary IFUNC addition
reloc.c is conditionally included by libc_start1.c so existing builds
don't feature it in the .depend file and won't know they need to rebuild
libc_start1.c.
MFC after: 1 week
(cherry picked from commit d41a40f484826e90ed78dce5f006712b0eeaf501)
Commit: 1374db1c188ddc3a6c9303a7f011ab27978caf39
https://github.com/MidnightBSD/src/commit/1374db1c188ddc3a6c9303a7f011ab27978caf39
Author: Jessica Clarke <jrtc27 at FreeBSD.org>
Date: 2026-01-18 (Sun, 18 Jan 2026)
Changed paths:
M tools/build/cross-build/include/linux/limits.h
Log Message:
-----------
tools/build/cross-build: Don't include sys/uio.h from linux limits.h
This creates a circular dependency for OpenZFS's libspl in sys/uio.h,
and it shouldn't be needed since the system limits.h already defines
IOV_MAX, so delete it, and unconditionally assert that to be the case.
Otherwise the re-include of libspl's sys/uio.h tries to use PAGESIZE
before it has been defined by OpenZFS's own sys/param.h.
Fixes: 7a7741af18d6 ("zfs: merge openzfs/zfs at b10992582")
MFC after: 1 week
(cherry picked from commit 0bdf2535d4f8a571cb6d230f2f19eb20a452a4f8)
Compare: https://github.com/MidnightBSD/src/compare/dac4ab1a47b9...1374db1c188d
To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/src/settings/notifications
More information about the Midnightbsd-cvs
mailing list