[Midnightbsd-cvs] [MidnightBSD/src] ea4968: prowld: prevent sensitive data from reaching syslog

[Lucas Holt]

  Branch: refs/heads/feature/prowl
  Home:   https://github.com/MidnightBSD/src
  Commit: ea49688b7facacb09db633c76db6a77ec3d4a292
      https://github.com/MidnightBSD/src/commit/ea49688b7facacb09db633c76db6a77ec3d4a292
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-04-18 (Sat, 18 Apr 2026)

  Changed paths:
    M sbin/prowld/ipc.c
    M sbin/prowld/unit.c

  Log Message:
  -----------
  prowld: prevent sensitive data from reaching syslog

unit.c:
- Cap ucl_parser_get_error() output at 128 chars when logging unit file
  parse failures.  UCL error strings can include surrounding token text
  from the file being parsed; an environment= block containing a secret
  (API key, password) could otherwise appear verbatim in syslog.
- Add explicit comment near env processing: env VALUES must never be
  logged; only key names are safe to include in diagnostic messages.

ipc.c:
- Downgrade IPC JSON parse error from LOG_WARNING to LOG_DEBUG.
  A misbehaving or adversarial client can trigger this path repeatedly,
  flooding syslog at WARNING level.  Also cap the error string at 128
  chars to limit how much of the IPC payload context can reach the log.

AI-Assisted-by: Claude Sonnet 4.6
Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/src/settings/notifications