[Midnightbsd-cvs] [MidnightBSD/src] 952c1f: system(3): Clarify return values

Thu May 21 10:45:58 EDT 2026

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/src
  Commit: 952c1f5c0ae6de4eb1850b663eccaa81cd6b9825
      https://github.com/MidnightBSD/src/commit/952c1f5c0ae6de4eb1850b663eccaa81cd6b9825
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M lib/libc/stdlib/system.3

  Log Message:
  -----------
  system(3): Clarify return values

Our manual page currently states that system() will return 127 if it
fails to execute the shell.  The actual return value is, to quote POSIX,
“as if the command language interpreter had terminated using exit(127)
or _exit(127)”.

MFC after:	1 week
Sponsored by:	Klara, Inc.
Reviewed by:	bnovkov, kevans
Differential Revision:	https://reviews.freebsd.org/D55483

(cherry picked from commit 7305604b29d3db29c9bb5de6e7a25829fb541d1e)

  Commit: daad6997aecbe0a3b3fca489666daaa8516bf4e8
      https://github.com/MidnightBSD/src/commit/daad6997aecbe0a3b3fca489666daaa8516bf4e8
  Author: Chris Rees <crees at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/lpr/lpd/lpd.8
    M usr.sbin/lpr/lpd/lpd.c

  Log Message:
  -----------
  lpd: Add -F flag to prevent daemonizing

This is necessary for use with supervision, e.g. runit.

I chose -F simply because that is what the folks at LPRng use.

Approved by:		pfg, gad, ngie
Differential Revision:	https://reviews.freebsd.org/D29566

(cherry picked from commit 3c6366067036d4573528309a0a4d3b52e2a76ae7)

  Commit: 3169dec9748718581ef701cba96d6c3164069ff9
      https://github.com/MidnightBSD/src/commit/3169dec9748718581ef701cba96d6c3164069ff9
  Author: Chris Rees <crees at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/lpr/lpd/lpd.8

  Log Message:
  -----------
  lpd.8: Chase Dd-- took old value when merging

(cherry picked from commit 56b0f5f360b6039c6a696aa241aaa02a16ff6a0a)

  Commit: 71af5b858cc14a9b8a003f3b7fe34f5a19e24468
      https://github.com/MidnightBSD/src/commit/71af5b858cc14a9b8a003f3b7fe34f5a19e24468
  Author: Chris Rees <crees at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/lpr/lpd/lpd.8

  Log Message:
  -----------
  lpd: Update SYNOPSIS with new flag

Reported by:	0mp

(cherry picked from commit cebcca89f1b059438cc329bde4d8ad254a303623)

  Commit: c7899ff7715db057ba7149fa9827de1487bb9bf5
      https://github.com/MidnightBSD/src/commit/c7899ff7715db057ba7149fa9827de1487bb9bf5
  Author: Elyes Haouas <ehaouas at noos.fr>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/lpr/lpd/recvjob.c

  Log Message:
  -----------
  lpr: Remove trailing semicolon

Signed-off-by: Elyes Haouas <ehaouas at noos.fr>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/654
(cherry picked from commit 365348f66a47df247b5289b8a86fb20b36d778c1)

  Commit: 90afba350c0b73c5735eab7b7f7685e286e43f92
      https://github.com/MidnightBSD/src/commit/90afba350c0b73c5735eab7b7f7685e286e43f92
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/lpr/lpd/recvjob.c

  Log Message:
  -----------
  lpd: Improve robustness

* Check for integer overflow when receiving file sizes.

* Check for buffer overflow when receiving file names, and fully
  validate the names.

* Check for integer overflow when checking for available disk space.

* Check for I/O errors when sending status codes.

* Enforce one job per connection and one control file per job (see
  code comments for additional details).

* Simplify readfile(), avoiding constructs vulnerable to integer
  overflow.

* Don't delete files we didn't create.

* Rename read_number() to read_minfree() since that's all it's used
  for, and move all the minfree logic into it.

* Fix a few style issues.

PR:		293278
MFC after:	1 week
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D55399

(cherry picked from commit 9065be0a5902e058d25a42bd9b3fbe9dc28b189d)

  Commit: 3646ab8cef3784cb7fe8073edd242bf044c1ae9d
      https://github.com/MidnightBSD/src/commit/3646ab8cef3784cb7fe8073edd242bf044c1ae9d
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/lpr/lpd/lpd.8
    M usr.sbin/lpr/lpd/lpd.c

  Log Message:
  -----------
  lpd: Add timeout option

Set a 120-second receive timeout on all client connections, and add a
command-line option to change that value.

MFC after:	1 week
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D55400

(cherry picked from commit 56fbfd1ecdc78fc99b3a2e381c355ce8980de39d)

  Commit: 7f2b8b7eb2c56ee385ec16784ffbe65bafa39c74
      https://github.com/MidnightBSD/src/commit/7f2b8b7eb2c56ee385ec16784ffbe65bafa39c74
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M lib/libiscsiutil/Makefile
    M share/mk/src.libnames.mk
    M usr.sbin/ctld/Makefile
    M usr.sbin/iscsid/Makefile

  Log Message:
  -----------
  libiscsiutil: Record dependency on libmd

MFC after:	3 days
Fixes:		6378393308bc ("Add an internal libiscsiutil library.")
Sponsored by:	Klara, Inc.
Sponsored by:	NetApp, Inc.
Reviewed by:	kevans
Differential Revision:	https://reviews.freebsd.org/D55596

(cherry picked from commit 05ca4837a3e9a413aabcf005abb14fff35088476)

  Commit: c26d33dd600860e58cc7ea7d44908757c45273f9
      https://github.com/MidnightBSD/src/commit/c26d33dd600860e58cc7ea7d44908757c45273f9
  Author: Zhenlei Huang <zlei at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/net/vnet.c

  Log Message:
  -----------
  vnet: Ensure the space allocated by vnet_data_alloc() is sufficent aligned

Some 32-bit architectures, e.g., armv7, require strict 8-byte
alignment while doing atomic 64-bit access. Hence aligning to the
pointer type (4-byte alignment) does not meet the requirement on
those architectures.

Make the space allocated by vnet_data_alloc() sufficent aligned to
avoid unaligned access.

PR:		265639
Diagnosed by:	markj
Reviewed by:	jhb, markj
Co-authored-by:	jhb
MFC after:	5 days
Differential Revision:	https://reviews.freebsd.org/D55560

(cherry picked from commit 32beb3ae71cb320dbe4190a01c036943d99083b3)
(cherry picked from commit 973d607b284ba68e63f0386af44c28bfde15add2)
(cherry picked from commit baee504b868b9417c815c0de6474a0d6e5d6b4ac)

  Commit: 3cd7e5fcd655095ef0870ad509cf4156011bbf5b
      https://github.com/MidnightBSD/src/commit/3cd7e5fcd655095ef0870ad509cf4156011bbf5b
  Author: Eugene Grosbein <eugen at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M share/man/man4/Makefile

  Log Message:
  -----------
  me.4: MFC: link if_me kernel module to its manual page.

(cherry picked from commit 46ba263d6eeb1c6029841b4c42f54912ad61de5c)

  Commit: 906f89a32ef4529abe04bab9bcb4957a0fd44042
      https://github.com/MidnightBSD/src/commit/906f89a32ef4529abe04bab9bcb4957a0fd44042
  Author: Zhenlei Huang <zlei at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/net/if.c

  Log Message:
  -----------
  ifnet: Fix decreasing the vnet interface count

It should be decreased only when the interface has been successfully
removed from the "active" list.

This prevents vnet_if_return() from potential OOB writes to the
allocated memory "pending".

Reviewed by:	kp, pouria
Fixes:		a779388f8bb3 if: Protect V_ifnet in vnet_if_return()
MFC after:	3 days
Differential Revision:	https://reviews.freebsd.org/D55873

(cherry picked from commit 8065ff63c0e5c3bb4abb02f55b20cb47bb51d1a7)
(cherry picked from commit 1b7687f053afcf251ee7643ee5a4f22a225f4a02)
(cherry picked from commit 47339e4a9209c1d1323f58d792e277792990e060)

  Commit: ad71cc1d7a15e3f999f951a47c1d35f98e549873
      https://github.com/MidnightBSD/src/commit/ad71cc1d7a15e3f999f951a47c1d35f98e549873
  Author: Michael Gmelin <grembo at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/netpfil/pf/pf_ioctl.c

  Log Message:
  -----------
  pf: Fix hashing of IP address ranges

This corrects the false detection of duplicate rules.

MFC after:	1 week
Reviewed by:	kp

(cherry picked from commit 1fa873c93c8b08561c53107c7b90c53dfad30ddc)

  Commit: 819a4c6819bf237a3f23ea821ad9dd63f6db856d
      https://github.com/MidnightBSD/src/commit/819a4c6819bf237a3f23ea821ad9dd63f6db856d
  Author: Kristof Provost <kp at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M tests/sys/netpfil/pf/pass_block.sh

  Log Message:
  -----------
  pf tests: verify that we handle address range rules correctly

There's been a problem where rules which differed only in address ranges
were considered duplicates and not added. Test for this.

MFC after:	1 week
Sponsored by:	Rubicon Communications, LLC ("Netgate")

(cherry picked from commit ab74151e8d097b263237942c0b12277098bc9533)

  Commit: e38879946fd1c9a60407eb743622a275bc8464f2
      https://github.com/MidnightBSD/src/commit/e38879946fd1c9a60407eb743622a275bc8464f2
  Author: Kristof Provost <kp at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/netpfil/pf/pf_ioctl.c

  Log Message:
  -----------
  pf: include all elements when hashing rules

MFC after:	1 week
Sponsored by:	Rubicon Communications, LLC ("Netgate")

(cherry picked from commit c6bcf6e6fd507d952a48226b51cc161b8ef972a2)

  Commit: c45b31c7b5dbe8e62a7990802164fc3e7ba2325f
      https://github.com/MidnightBSD/src/commit/c45b31c7b5dbe8e62a7990802164fc3e7ba2325f
  Author: Marc Espie <espie at openbsd.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.bin/m4/eval.c
    M usr.bin/m4/extern.h
    M usr.bin/m4/look.c
    M usr.bin/m4/main.c
    M usr.bin/m4/mdef.h
    M usr.bin/m4/misc.c

  Log Message:
  -----------
  m4: Stop abbreviating builtin names

* Stop abbreviating macro names half-randomly to 8 chars, this is no
  longer 1990.

* Likewise for function names (in particular use doindex for a function
  that is notably different from the classic index function).

* Rename a few things for more fidelity: eval is the builtin name, not
  expr and your maketemp/mkstemp conform to mkstemp semantics for better
  security.

* Rewrap a few comments that were ludicrously short.

No functional changes except improved accuracy of some error messages.

MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D55793

(cherry picked from commit f8f6f1cbd576ab5f15cef178cc05251365652f74)

  Commit: 4386ddabed533be89ddea9a0af9634820973bf4f
      https://github.com/MidnightBSD/src/commit/4386ddabed533be89ddea9a0af9634820973bf4f
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M usr.sbin/syslogd/syslogd.c

  Log Message:
  -----------
  syslogd: Allow killing when in foreground

Normally, syslogd reacts only to SIGTERM, and ignores SIGINT and SIGQUIT
unless in debug mode.  Extend that to also apply when running in the
foreground.

MFC after:	1 week
Reviewed by:	jfree
Differential Revision:	https://reviews.freebsd.org/D55886

(cherry picked from commit 828de702ada854b5f09f447ba06e4e08e976ba07)

  Commit: e334cb400f886bd55bc294a61cde10dc282164fa
      https://github.com/MidnightBSD/src/commit/e334cb400f886bd55bc294a61cde10dc282164fa
  Author: Jessica Clarke <jrtc27 at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M tools/build/Makefile
    M tools/build/cross-build/include/mac/string.h

  Log Message:
  -----------
  cross-build: Provide mempcpy when building on macOS

We could patch the tzcode config to not use it, but it's simple to
provide an implementation of it and avoid spreading cross-build
bootstrapping special cases.

Fixes:		ff2c98b30b57 ("tzcode: Update to 2026a")
MFC after:	1 week

(cherry picked from commit 47402c9422ec6c9ba76d96414f5a08bd35a9e1fd)

  Commit: 4aab3a6e2e12aa5fce701b79d97cbde7fdb5d5ad
      https://github.com/MidnightBSD/src/commit/4aab3a6e2e12aa5fce701b79d97cbde7fdb5d5ad
  Author: Arthur Kiyanovski <akiyano at amazon.com>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/dev/ena/ena.c
    M sys/dev/ena/ena_rss.h

  Log Message:
  -----------
  ena: Minor changes

1. Move parenthesis to correct place in switch and fix include order
2. Add comment at the end of an ifdef for clarity
3. Change include order.

Reviewed by: cperciva
Differential Revision: https://reviews.freebsd.org/D55696
Sponsored by: Amazon, Inc.

(cherry picked from commit 2667a8454cff5896c7b467c78cd4ace5ad40f5eb)

  Commit: f84fdb75d63fabc80c6e492222b57f8f4477f12c
      https://github.com/MidnightBSD/src/commit/f84fdb75d63fabc80c6e492222b57f8f4477f12c
  Author: Arthur Kiyanovski <akiyano at amazon.com>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/dev/ena/ena_netmap.c

  Log Message:
  -----------
  ena: Verify that an ENA ring is in netmap only in native mode

netmap operates in two modes:
1) Emulated - netmap handling is done by the network stack, the
NIC driver operates transparently to netmap.
2) Native - netmap management is done by the NIC driver.

When checking whether a specific ENA ring is running in netmap
mode, only the following checks were done:
1. IFCAP_NETMAP - Check whether netmap capability is enabled on
the device.
2. NKR_NETMAP_ON - Check whether netmap is actively using this
ring.

The above checks implied that the netmap mode is native and the
ENA driver needs to handle the netmap logic.
The code was missing an explicit check on whether native mode
is actually on (NAF_NATIVE).
This led to a case where though emulated mode was used and
a netmap application was turned on, the ENA driver still managed
netmap logic partially and caused missing buffers and lack of
refill as part of the datapath.

Note: Enabling netmap emulated mode is insufficient and there's
a need to load a netmap program in order to trigger this use-case.

Add an explicit check of whether NAF_NATIVE mode is set.

The issue was reported in [1].

[1]: https://github.com/amzn/amzn-drivers/issues/361

Fixes: 358bcc4c6cde ("Add support for ENA NETMAP partial initialization")
Reviewed by: cperciva
Differential Revision: https://reviews.freebsd.org/D55697
Sponsored by: Amazon, Inc.

(cherry picked from commit 97e84c587d6f86aa883720296449b380adcf6915)

  Commit: e2ba5f1fbbf874f90323c011cdbc5dd9cb2a028a
      https://github.com/MidnightBSD/src/commit/e2ba5f1fbbf874f90323c011cdbc5dd9cb2a028a
  Author: Arthur Kiyanovski <akiyano at amazon.com>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/dev/ena/ena.h

  Log Message:
  -----------
  ena: Update driver version to v2.8.2

Bug Fixes:
* Verify that an ENA ring is in netmap only in native mode

Minor Changes:
* Move parenthesis to correct place in switch
* Add comment
* Reorder define

Reviewed by: cperciva
Differential Revision: https://reviews.freebsd.org/D55698
Sponsored by: Amazon, Inc.

(cherry picked from commit 96c5eaf0ac6b98d0832e1037d672064de43a7e00)

  Commit: f9a4bfb10aa8fcd068eb5ab5a1f55ceef42994b2
      https://github.com/MidnightBSD/src/commit/f9a4bfb10aa8fcd068eb5ab5a1f55ceef42994b2
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sbin/newfs/newfs.8
    M sbin/newfs/newfs.c

  Log Message:
  -----------
  newfs: Don't combine GEOM journaling with SU

GEOM journaling shouldn't be used at the same time as soft updates, so
don't enable soft updates if GEOM journaling has been requested, and
error out if both are explicitly requested.

MFC after:	1 week
PR:		293896
Reviewed by:	mckusick
Differential Revision:	https://reviews.freebsd.org/D55999

(cherry picked from commit e30fcdaae2e68458da83d5420e6034c5f384e5f2)

  Commit: 1652b21be31b7f75854470fc6cc616610c922cf2
      https://github.com/MidnightBSD/src/commit/1652b21be31b7f75854470fc6cc616610c922cf2
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sbin/tunefs/tunefs.8
    M sbin/tunefs/tunefs.c

  Log Message:
  -----------
  tunefs: Don't combine GEOM journaling with SU

GEOM journaling shouldn't be used at the same time as soft updates, so
don't enable one if the other is already in use.

MFC after:	1 week
PR:		293896
Reviewed by:	mckusick
Differential Revision:	https://reviews.freebsd.org/D56002

(cherry picked from commit b1f72dd2a9a5e69a310b9e76b55f16cff433b8da)

  Commit: fcfeaa489bcede01ee6e68974c5eafa373a3c44f
      https://github.com/MidnightBSD/src/commit/fcfeaa489bcede01ee6e68974c5eafa373a3c44f
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M sys/fs/cd9660/cd9660_rrip.c

  Log Message:
  -----------
  cd9660: Add length checks to Rock Ridge parser

* cd9660_rrip_slink() did not check that the lengths of individual
  entries do not exceed the length of the overall record.

* cd9660_rrip_altname() did not check that the length of the record
  was at least 5 before subtracting 5 from it.

Note that in both cases, a better solution would be to check the length
of the data before calling the handler, or immediately upon entry of
the handler, but this would require significant refactoring.

MFC after:	1 week
Reported by:	Calif.io in collaboration with Claude and Anthropic Research
Reported by:	Adam Crosser, Praetorian
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D56215

(cherry picked from commit d0afead876076f605c363f03d92304d1bd75be1c)

  Commit: d421b7a61bc7f33e4a4c9dfb675d899b11420595
      https://github.com/MidnightBSD/src/commit/d421b7a61bc7f33e4a4c9dfb675d899b11420595
  Author: Dag-Erling Smørgrav <des at FreeBSD.org>
  Date:   2026-05-21 (Thu, 21 May 2026)

  Changed paths:
    M lib/libc/gen/Makefile.inc

  Log Message:
  -----------
  libc: Add missing MLINK for stravis(3)

MFC after:	1 week
Fixes:		8dfeba04eb36 ("Update to a June 8th snapshot of (un)vis form NetBSD.")
Reviewed by:	ziaee
Differential Revision:	https://reviews.freebsd.org/D56260

(cherry picked from commit a09d06bc5bff64baab76220a66c3501b89899134)

Compare: https://github.com/MidnightBSD/src/compare/f551db24a7fa...d421b7a61bc7

To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/src/settings/notifications