[Midnightbsd-cvs] [MidnightBSD/src] b51683: secure/libssh: drop ssh-dss.c (DSA removed in Open...

[Lucas Holt]

  Branch: refs/heads/fix/openssh-remove-stale-dss
  Home:   https://github.com/MidnightBSD/src
  Commit: b51683cf8fb173a2fa4f1220390b2e6b2f129ae3
      https://github.com/MidnightBSD/src/commit/b51683cf8fb173a2fa4f1220390b2e6b2f129ae3
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    R crypto/openssh/ssh-dss.c

  Log Message:
  -----------
  secure/libssh: drop ssh-dss.c (DSA removed in OpenSSH 10)

The OpenSSH 10.3p1 update (8de6e3dc9d) rewrote struct sshkey to store
libcrypto keys in an EVP_PKEY and removed the legacy `dsa` member along
with DSA support, but the stale ssh-dss.c was left behind and still listed
in libssh's SRCS, breaking the build:

    crypto/openssh/ssh-dss.c:55:11: error: no member named 'dsa' in 'struct sshkey'

Nothing else references the DSS key implementation (sshkey.c's impl table
has no DSS entry), so remove ssh-dss.c from secure/lib/libssh/Makefile and
delete the orphaned file, matching upstream OpenSSH 10.x.

Verified: secure/lib/libssh builds and links (libprivatessh.so.5) cleanly.

Co-Authored-By: Claude Opus 4.8 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/src/settings/notifications