[Midnightbsd-cvs] [MidnightBSD/mports] 81b9f7: devel/electron40: fix fetch on clean builders

[Lucas Holt]

  Branch: refs/heads/devel/electron40
  Home:   https://github.com/MidnightBSD/mports
  Commit: 81b9f7d4e068d1b18090231d24a10bae5c0e058d
      https://github.com/MidnightBSD/mports/commit/81b9f7d4e068d1b18090231d24a10bae5c0e058d
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-07-31 (Fri, 31 Jul 2026)

  Changed paths:
    M devel/electron40/Makefile
    M devel/electron40/distinfo

  Log Message:
  -----------
  devel/electron40: fix fetch on clean builders

The port has never fetched successfully on a machine without a pre-populated
Distfiles directory, which is why Magus reports fetch failures on both 4.0 and
4.1/amd64. Three separate defects:

1. pre-fetch ordering. electron-fetch-node-modules untars the Electron source
   tarball to read package.json/yarn.lock, but pre-fetch runs before do-fetch,
   so the tarball is not there yet. It only worked where the distfile happened
   to be cached already. Fetch it explicitly in a new electron-fetch-source
   target, mirroring what electron-fetch-node-package-manager already does for
   yarn.

2. The generated node-modules offline cache was not reproducible: it was
   archived with a plain `tar -cJf` with no entry ordering or timestamp
   normalisation, so its checksum could never match distinfo elsewhere. The
   recorded distinfo entry (59792711 bytes) did not match a regenerated
   tarball at all. Sort the entries and zero timestamps/uid/gid the same way
   ai/llama-cpp does for its WebUI cache; two independent cold runs now produce
   byte-identical output. distinfo regenerated to match.

3. node was only a BUILD_DEPENDS, but pre-fetch runs corepack to drive yarn,
   so it has to be a FETCH_DEPENDS too.

Also sync ESBUILD_VER with the updated devel/esbuild (0.28.1) and drop the
stale note about devel/esbuild not existing in mports.

Verified: with an empty node-modules distfile, `bmake checksum` now fetches and
regenerates everything and all checksums pass. The full build is unchanged by
this commit and was not run.

AI-Assisted-by: Claude Opus 5 (1M context) <noreply at anthropic.com>
Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications