[Midnightbsd-cvs] [MidnightBSD/mports] f00efc: mail/roundcube: update to 1.7.2 (#702)

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: f00efc8adb53f9a33d6b9f8835eef7aac9784749
      https://github.com/MidnightBSD/mports/commit/f00efc8adb53f9a33d6b9f8835eef7aac9784749
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M mail/roundcube/Makefile
    M mail/roundcube/distinfo
    M mail/roundcube/files/patch-config_defaults.inc.php
    M mail/roundcube/files/patch-program_lib_Roundcube_rcube_message.php
    M mail/roundcube/pkg-message

  Log Message:
  -----------
  mail/roundcube: update to 1.7.2 (#702)

Update `mail/roundcube` from 1.6.16 to 1.7.2. This is a minor-version
jump, not a patch bump.

## Real breakage found

1.7.2 no longer ships a top-level `.htaccess`, but mports carried it in
`RCUBECOMP` (FreeBSD never did). `COPYTREE_SHARE` on a missing source
would have failed `do-install`. Each `RCUBECOMP` member was verified
with `test -e`; only `.htaccess` was missing, so it was dropped. The
four **nested** `.htaccess` files (`config/`, `logs/`, `public_html/`,
`temp/`) are still collected by the recursive `FIND`, so nothing is lost
from the package. This isn't discarding mports delta — the delta had
gone stale.

## Patch set

Both patches were 1.6-era and would **not** have applied to 1.7.2
(`patch-config_defaults.inc.php` was pinned at `@@ -739` with 2017
context; the real hunk in 1.7.2 is near line 1009). Contents replaced
with FreeBSD's 1.7.2 versions, mports filenames kept — deliberately
**not** adopting FreeBSD's doubled-underscore
`patch-program_lib_Roundcube_rcube__message.php` name, which would have
left the single-underscore file in place and applied the same hunk
twice. Neither patch was upstreamed; both are still needed. `bmake
patch` applies cleanly with no fuzz and no `.rej`/`.orig`.

## pkg-message — one deliberate divergence from FreeBSD

FreeBSD's 1.7 breaking-changes block carries `maximum_version: "1.6.0"`,
which gates the notice to users coming from ≤1.6.0 — so nobody on
1.6.1–1.6.16 would ever see it. Ours uses `"1.7.0"`. The 1.6 skins block
was **added to** rather than replaced, since `mail/roundcube-larry` and
`mail/roundcube-classic` both still exist in mports. Also fixed a
`rouncube` typo in that reference.

Verified by extracting the built `.mport` and confirming the message is
embedded and the UCL parsed — a successful `bmake package` alone
wouldn't prove that.

## PHP version

No change needed. 1.7.2's `composer.json` requires `"php": ">=8.1
<8.6"`; mports flavors are php82–php85 (default 8.3), so every flavor
satisfies it. Matches FreeBSD's unconstrained `php:web,flavors`.

## pkg-plist

This port has no static `pkg-plist` — `do-install` generates it by
walking `bin` + `RCUBECOMP` and appending to `TMPPLIST`. `bmake
makeplist` was deliberately not run, since a static plist layered on the
dynamic one appends rather than replaces. The 1.6→1.7 file churn is
absorbed automatically; the generated `.PLIST.mktmp` came out at 3167
entries.

## Verification

`makesum`, `patch`, `build`, `fake`, `package` all succeeded →
`roundcube-php83-1.7.2,1.mport`. distinfo matches FreeBSD's
byte-for-byte. `portlint`: 0 fatal, 4 warnings, all on untouched lines.

LICENSE is not a relicense — `composer.json` still declares
GPL-3.0-or-later, matching the existing `gpl3+`. Only the license file
path moved to `docs/LICENSE.md`.

**Not validated:** php83 flavor only, amd64. `do-install-NSC-on` was not
exercised (NSC is off by default).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Summary by Sourcery

Update the Roundcube port to 1.7.2 and align packaging, local patches,
and messages with the new upstream layout and FreeBSD’s 1.7.2 port.

Bug Fixes:
- Refresh the local attachment-handling and spellchecker configuration
patches so they still apply cleanly against Roundcube 1.7.2.

Enhancements:
- Adjust installed documentation and license paths to match Roundcube
1.7.2’s new docs layout and filenames.
- Stop including the obsolete top-level .htaccess from RCUBECOMP while
retaining nested .htaccess files collected recursively.
- Tweak pkg-message version gating and content so 1.6.x users upgrading
to 1.7.x still see the relevant breaking-changes and skins notices.

Build:
- Update DISTVERSION and distinfo and keep the dynamic plist generation
compatible with the 1.7.2 distfile contents.

Documentation:
- Update installed documentation files to the new
INSTALL.md/UPGRADING.md locations under docs/ and fix a typo in the
pkg-message.

Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications