[Midnightbsd-cvs] [MidnightBSD/mports] 873f09: mail/msmtp: update to 1.8.34 (#731)

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: 873f09f39408f7319c6196813ff655e72ba43ffb
      https://github.com/MidnightBSD/mports/commit/873f09f39408f7319c6196813ff655e72ba43ffb
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-08-09 (Sun, 09 Aug 2026)

  Changed paths:
    M mail/msmtp/Makefile
    M mail/msmtp/distinfo
    R mail/msmtp/files/patch-src_base64.h

  Log Message:
  -----------
  mail/msmtp: update to 1.8.34 (#731)

Update `mail/msmtp` from 1.8.33 to 1.8.34.

## The patch added last release is already obsolete

`files/patch-src_base64.h` was added for 1.8.33 to supply a missing
`#include <stdbool.h>`. Upstream's gnulib re-import in 1.8.34 now
carries that include itself at `src/base64.h:21`, so the patch fails:

```
Ignoring previously applied (or reversed) patch.
1 out of 1 hunks ignored--saving rejects to src/base64.h.rej
===>  FAILED Applying MidnightBSD patch-src_base64.h
```

That's genuine obsolescence, not context drift, so the correct fix is
deletion rather than a rewrite. Confirmed by a clean build with no patch
present — no `stdbool`/`bool` errors in `base64.c`/`base64.o`. `files/`
is now empty again.

Upstream `NEWS` for 1.8.34 says verbatim: *"No significant changes."*
The gnulib re-import is the only build-relevant one.

## Verification

makesum OK; patch failed, then OK after removing the obsolete patch
against a freshly extracted tree; build/fake/package OK →
`msmtp-1.8.34.mport`. distinfo matches FreeBSD exactly. LICENSE
unchanged (`COPYING` still GPL v3). pkg-plist unchanged — empty diff vs
FreeBSD's 1.8.34.

MidnightBSD delta re-verified as still live: the `post-extract`
CERTSFILE rewrite still matches on 1.8.34 — `doc/msmtp.1` has 1
occurrence of `ca-root-nss.crt` and 0 of the Debian
`ca-certificates.crt` path.

Kept `PORTVERSION` rather than adopting FreeBSD's `DISTVERSION`. No
`PORTREVISION` line exists, so none was added.

## Worth knowing: stale work dirs cause false greens

Both this port and courier-imap had leftover `work/` trees from the
previous build. Running `bmake NOCLEANDEPENDS=yes clean` first was
necessary — without it the extract cookie makes `bmake patch` pass
against the **old** sources, which is a false green on precisely the
check that mattered here.

## FreeBSD delta deliberately not imported

Out of scope for a version bump, listed so it can be decided separately:
`WWW=`, `GNU_CONFIGURE_MANPREFIX`, `shebangfix` + `SHEBANG_FILES`,
`TEST_DEPENDS= bash` + `TEST_TARGET= check`, and the
`post-install-MSMTPQ-on` suffixed-target form (mports uses the plain
`.if MSMTPQ` / `post-install:` with bare `${PREFIX}`, which is correct
here). Their `PATCH_SITES` is dead config on the FreeBSD side too — no
`PATCHFILES`, no patch entry in their distinfo.

**Not run:** `bmake test` — mports has no `TEST_TARGET` for this port
and importing FreeBSD's would require installing `shells/bash`. The
OPENSSL radio arm was not built (default is GNUTLS). amd64 only.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Summary by Sourcery

Enhancements:
- Remove obsolete base64 header patch that is now provided by upstream
gnulib in msmtp 1.8.34.

Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications