[Midnightbsd-cvs] [MidnightBSD/mports] 860c3f: mail/thunderbird: update to 153.0.2 (#734)

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: 860c3fdd4fc63fac287f3391de0251a439462859
      https://github.com/MidnightBSD/mports/commit/860c3fdd4fc63fac287f3391de0251a439462859
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M mail/thunderbird/Makefile
    M mail/thunderbird/distinfo
    M mail/thunderbird/files/patch-toolkit_components_protobuf_src_google_protobuf_thread__safe__arena.h

  Log Message:
  -----------
  mail/thunderbird: update to 153.0.2 (#734)

Update `mail/thunderbird` from 153.0 to 153.0.2.

## Nothing to sync from FreeBSD — verified, not assumed

`git show --stat` on FreeBSD's `dab724096230` (153.0.1) and
`a44d0f9f4a1f` (153.0.2) confirms both commits touched **only**
`Makefile` and `distinfo` — zero patch changes. The four shared patches
that differ between the trees (`patch-hal_moz.build`,
`patch-python_sites_mach.txt`, `patch-build_gn__processor.py`,
`patch-third__party_sqlite3_ext_sqlite-vec_sqlite-vec.c`) are deliberate
MidnightBSD forms and all applied cleanly, so they were left untouched.

The candidates path moves `build1` → `build2`, matching FreeBSD's
153.0.2.

## One patch was malformed and is now fixed


`patch-toolkit_components_protobuf_src_google_protobuf_thread__safe__arena.h`
failed:

```
===> FAILED to apply cleanly MidnightBSD patch(es)
patch-toolkit_components_protobuf_src_google_protobuf_thread__safe__arena.h
```

Its second hunk targets `arena.cc` with header `@@ -539,7 +539,7 @@` but
supplied only **4** body lines. That bad count happened to work at
153.0; once `arena.cc` line numbering shifted it could no longer match.
The three missing context lines are restored (`}` plus two blanks before
the `alignas`, and `#if defined(PROTOBUF_NO_THREADLOCAL)` /
`ThreadSafeArena::ThreadCache& ...` after). Both hunks verified applied
at `arena.cc:542` and `thread_safe_arena.h:261`. `bmake makepatch` was
not used.

This patch is **MidnightBSD-only** — FreeBSD has no equivalent — and it
exists specifically for i386 atomic alignment.

Note for anyone reproducing: the first hunk applies before the second
fails, leaving a half-patched tree, so a `bmake clean` and full
re-extract is required before retrying.

## Verification

makesum OK — SHA256 `0b79f19e…c14f` and SIZE `938263468` match FreeBSD's
distinfo exactly. patch OK after the hunk fix. build/fake/package OK →
`thunderbird-153.0.2.mport` (77,371,532 bytes).

**Dependencies unchanged**; all build deps were already installed
(llvm19-19.1.7_1, rust-1.94.0_1, rust-cbindgen-0.29.4, node24-24.13.0_1,
nasm, yasm, zip). Nothing else on the host was built or installed.

**LICENSE** `MPL20` unchanged. **pkg-plist** needs no changes — the
staged tree matches exactly; the only extras are framework-generated
`share/licenses/thunderbird-153.0.2/*`.

### Regression check carried over from 152.0.1

Re-checked the libproxy `GetSystemProxyDirect` regression class, which
builds, links and packages cleanly and only fails at dlopen — i.e.
exactly the kind a green build won't catch. `llvm-nm -D` reads
`libxul.so` fine (2791 dynamic symbols) and shows
`px_proxy_factory_*@LIBPROXY_0.4.16` undefined, confirming libproxy is
genuinely linked, with **no** undefined `nsUnixSystemProxySettings` C++
symbols. The regression is not present. `files/patch-bug2040125` was
intentionally dropped in `b9b067e093`; upstream carries the fix now.

**This is static analysis only** — the package was not installed and
153.0.2 has not been smoke-tested by launching it.

## Reported, not applied

FreeBSD added `NOT_FOR_ARCHS= i386` in `368d875486b9` ("rust needs more
address space than platform can provide"). **Not adopted** — MidnightBSD
supports i386, and dropping an architecture is a compatibility decision
that doesn't belong in a patch-level bump. Worth a separate decision,
especially given the protobuf patch above exists for i386.

amd64 only. Build time was roughly 30 min compile, ~10 min fake+package,
~11 min for the 938 MB fetch.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Summary by Sourcery

Update the MidnightBSD thunderbird port to release 153.0.2 and adjust
source download candidate path, while correcting an i386-specific
protobuf arena alignment patch so it applies cleanly against the new
upstream sources.

Bug Fixes:
- Fix the malformed protobuf ThreadSafeArena alignment patch so it
applies cleanly to arena.cc and thread_safe_arena.h for i386.

Build:
- Update thunderbird DISTVERSION and candidate build path in the port
Makefile to fetch 153.0.2 sources.

Chores:
- Refresh distinfo for the new thunderbird 153.0.2 distfile.

Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications