[Midnightbsd-cvs] [MidnightBSD/mports] e13847: cad/freecad: drop patches obsoleted by 1.1.1 (#866)

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: e13847d67c655793d37a92c0763cbcc203a69279
      https://github.com/MidnightBSD/mports/commit/e13847d67c655793d37a92c0763cbcc203a69279
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-07 (Mon, 07 Sep 2026)

  Changed paths:
    R cad/freecad/files/patch-cMake_FreeCAD__Helpers_SetupSalomeSMESH.cmake
    R cad/freecad/files/patch-src_3rdParty_libE57Format_src_CheckedFile.cpp
    M cad/freecad/files/patch-src_Gui_CMakeLists.txt
    R cad/freecad/files/patch-src_Gui_Selection.h
    R cad/freecad/files/patch-src_Gui_SoFCCSysDragger.cpp
    R cad/freecad/files/patch-src_Gui_SoFCSelection.h
    R cad/freecad/files/patch-src_Gui_SoFCUnifiedSelection.h
    R cad/freecad/files/patch-src_Mod_MeshPart_App_CMakeLists.txt
    R cad/freecad/files/patch-src_Mod_Part_App_Geometry2d.cpp

  Log Message:
  -----------
  cad/freecad: drop patches obsoleted by 1.1.1 (#866)

Fixes #856.

## Problem

The port stopped at the patch stage on 1.1.1. The SetupSalomeSMESH patch
reported in the issue was the first failure, but once past it six more
patches also failed or had been merged upstream. Every remaining patch
was checked against the 1.1.1 tree with `patch --dry-run`.

## Changes

Removed patches and why:

| Patch | Reason |
|---|---|
| `patch-cMake_FreeCAD__Helpers_SetupSalomeSMESH.cmake` | Upstream tries
`VTK 9` with `CommonCore` first, falls back to `vtkCommonCore` only if
not found |
| `patch-src_3rdParty_libE57Format_src_CheckedFile.cpp` | Upstream has
the BSD platform branch and `lseek()` fallback; `__FreeBSD__` is defined
on MidnightBSD |
| `patch-src_Gui_Selection.h`, `patch-src_Gui_SoFCSelection.h`,
`patch-src_Gui_SoFCUnifiedSelection.h` | Files moved to
`src/Gui/Selection/` and no longer use `std::array` |
| `patch-src_Gui_SoFCCSysDragger.cpp` | File no longer exists |
| `patch-src_Mod_MeshPart_App_CMakeLists.txt` | `pybind11_INCLUDE_DIR`
already present |
| `patch-src_Mod_Part_App_Geometry2d.cpp` | Upstream already uses
`std::endl` |

`patch-src_Gui_CMakeLists.txt` was regenerated so it applies without
fuzz (offset 39 lines previously).

## Validation

- `bmake patch` completes cleanly from a fresh extract on MidnightBSD
4.0.6 amd64.
- `portlint`: 0 fatal errors; remaining warnings are pre-existing
(`math/vtk` path, versioned ffmpeg sonames).
- **Not verified:** configure and build. This host lacks `math/vtk9` and
`cad/opencascade`, and a py311/py312 docutils conflict blocks the
`devel/pyside6-tools` build dependency chain. A Magus run or a clean
host build is needed to confirm the rest of the pipeline.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01QppyajU21HE92jbfdUgLSv

## Summary by Sourcery

Align the FreeCAD port's patch set with the 1.1.1 source tree so the
patch stage completes cleanly.

Bug Fixes:
- Update the FreeCAD 1.1.1 port so it completes the patch stage without
obsolete or upstream-integrated patches.

Enhancements:
- Remove patches superseded by FreeCAD 1.1.1 and refresh the GUI CMake
patch to apply cleanly.

Tests:
- Validate clean patch application from a fresh extract on MidnightBSD
4.0.6 amd64 and confirm portlint has no fatal errors.

Signed-off-by: Lucas Holt <luke at foolishgames.com>
Co-authored-by: Claude Fable 5.1 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications