[Midnightbsd-cvs] [MidnightBSD/mports] 897eb8: lang/php84: stop running the upstream test suite

[Lucas Holt]

  Branch: refs/heads/lang/php84
  Home:   https://github.com/MidnightBSD/mports
  Commit: 897eb8b3c645877ccb6ccf39d491d9a810b499d3
      https://github.com/MidnightBSD/mports/commit/897eb8b3c645877ccb6ccf39d491d9a810b499d3
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M lang/php84/Makefile

  Log Message:
  -----------
  lang/php84: stop running the upstream test suite

The port defined its own

	test: build
		@(cd ${WRKSRC} && ${MAKE} test)

which ran PHP's full upstream suite from the top of the source tree.  That
suite deadlocks in ext/standard/tests/streams (proc_open/pty): on magus run
646 lang/php84 entered the test phase on 2026-09-04 and was still sitting
there a week later, wedging worker 1 on m4164 and stalling the rest of the
run's test phase.

Because the rule defined target(test) itself, the guard in bsd.mport.mk that
honors NO_TEST/TESTING_UNSAFE was never emitted, so the phase could not be
turned off from the port at all.  Magus decides whether to skip by reading
"make -V NO_TEST", which was empty here.

Drop the override and set NO_TEST, matching lang/php82 and lang/php83.  Those
two set it at the top of the file; scope it to the main port instead so the
php84 extension subports keep their working TEST_TARGET=test.

No packaged content changes, so no PORTREVISION bump.

AI-Assisted-by: Claude Opus 5 <noreply at anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Claude-Session: https://claude.ai/code/session_017JRCQA17KgZSRk2vV96wbT
Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications