[Midnightbsd-cvs] [MidnightBSD/mports] 132764: net/samba419: fix staging path doubling in post-in...

[Lucas Holt]

  Branch: refs/heads/net/samba419-staging
  Home:   https://github.com/MidnightBSD/mports
  Commit: 13276458415d46c15364f9d71c188ceda1e5fd98
      https://github.com/MidnightBSD/mports/commit/13276458415d46c15364f9d71c188ceda1e5fd98
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M net/samba419/Makefile

  Log Message:
  -----------
  net/samba419: fix staging path doubling in post-install

With the platform detection fixed in c608a5c175 the port compiled but
failed while staging:

  ln: .../work/fake-inst-amd64/usr/mports/net/samba419/work/fake-inst-amd64/
      usr/local/share/man/man5/smb4.conf.5.gz: No such file or directory

fake redirects PREFIX to ${FAKE_DESTDIR}${TRUE_PREFIX} for the targets in
the plain post-install chain, so writing ${FAKE_DESTDIR}${PREFIX} there
prefixes it a second time. Drop the redundant prefix for ${PREFIX},
${DOCSDIR} and ${SAMBA4_MODULEDIR} in post-install, post-install-rm-junk
and post-install-fix-manpages.

Left alone, because fake does not redirect them:

- ${PYTHON_SITELIBDIR}, which derives from PYTHONBASE. That is a != shell
  assignment evaluated at parse time from sys.prefix, so it keeps the real
  path.
- ${SAMBA4_LOGDIR}, ${SAMBA4_RUNDIR}, ${SAMBA4_LOCKDIR},
  ${SAMBA4_BINDDNSDIR} and ${SAMBA4_PRIVATEDIR}, which live under /var.
- the option-conditional targets post-install-DOCS-on,
  post-install-FRUIT-off and post-install-CLUSTER-on. These are not run
  with the redirected PREFIX; with the prefix dropped there, the docs were
  written to the live /usr/local/share/doc/samba419 instead of the stage.

One .for loop mixed both kinds, creating the /var directories and
${SAMBA4_MODULEDIR} together, so ${SAMBA4_MODULEDIR} is now installed
separately.

samba419 builds, stages, packages and installs on amd64. This was the
last of four MidnightBSD-specific problems; with sysutils/libsunacl 1.0.1
(9e4227c587) and the platform and libutil patches (c608a5c175) in place,
the port works again.

AI-Assisted-by: Claude Opus 5 <noreply at anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Claude-Session: https://claude.ai/code/session_01NSsgED5s7GPYJNb1HxuaU9
Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications