From midnightbsd at bsdforge.com Thu Sep 23 13:32:54 2021 From: midnightbsd at bsdforge.com (Chris) Date: Thu, 23 Sep 2021 10:32:54 -0700 Subject: [Midnightbsd-mports] www/firefox* diffs Message-ID: <4e0874b881c45aaa732c04b6c8733652@bsdforge.com> Sorry I know the preferred method is via GitHub pull requests. But shortly after getting an account on GitHub a couple 3 years ago. I was unable to login. After some 30 days with tech support and no progress. I asked them to delete it. I don't have this problem with GitLab or Codeberg. Anyway. Please find attached 2 git(1) diff's; 1) www/firefox-esr (www-firefox-esr.diff 2) www/firefox (www-firefox.diff) In the case of firefox-esr, it's only "phase 1". I was able to eliminate all the errors emanating from the patches in files/. But as this is a fresh install on my laptop: ( MidnightBSD 2.1.0 #2 29cf808604(stable/2.1)-dirty: Mon Sep 20 18:25:51 EDT 2021 root at m2164: /usr/obj/usr/src/sys/GENERIC amd64 ) which isn't up to porting/development standards, This is as far as I can go till I can whip it into shape. I've been maintaining some 160 FreeBSD ports for around 7 years now. So this isn't unfamiliar territory. ;-) Tho there are some subtle differences. Which brings me to www/firefox. This one now builds and runs. But not w/o problems. So more investigation with firefox itself. To determine if it's just firefox or mports. Lastly; multimedia/x265 (a depends of multimedia/ffmpeg) a depends of firefox. Is a *very* unhappy port; dumping 10's of thousands of warnings for Bad Macro definitions. I mention it; as it may relate to the firefox unhappiness. That's it. Thanks! :-) --Chris P.S. This might appear as a "double post". I used the wrong From user name in the first posting. Sorry. :-( From midnightbsd at bsdforge.com Thu Sep 23 13:37:01 2021 From: midnightbsd at bsdforge.com (Chris) Date: Thu, 23 Sep 2021 10:37:01 -0700 Subject: [Midnightbsd-mports] www/firefox* diffs In-Reply-To: <4e0874b881c45aaa732c04b6c8733652@bsdforge.com> References: <4e0874b881c45aaa732c04b6c8733652@bsdforge.com> Message-ID: On 2021-09-23 10:32, Chris wrote: > Sorry I know the preferred method is via GitHub pull requests. > But shortly after getting an account on GitHub a couple 3 years > ago. I was unable to login. After some 30 days with tech support > and no progress. I asked them to delete it. > I don't have this problem with GitLab or Codeberg. > > Anyway. Please find attached 2 git(1) diff's; > 1) www/firefox-esr (www-firefox-esr.diff > 2) www/firefox (www-firefox.diff) > In the case of firefox-esr, it's only "phase 1". I was able to > eliminate all the errors emanating from the patches in files/. > But as this is a fresh install on my laptop: > ( MidnightBSD 2.1.0 #2 29cf808604(stable/2.1)-dirty: > Mon Sep 20 18:25:51 EDT 2021 root at m2164: > /usr/obj/usr/src/sys/GENERIC amd64 ) > which isn't up to porting/development standards, This is as far > as I can go till I can whip it into shape. I've been maintaining > some 160 FreeBSD ports for around 7 years now. So this isn't > unfamiliar territory. ;-) Tho there are some subtle differences. > Which brings me to www/firefox. This one now builds and runs. But > not w/o problems. So more investigation with firefox itself. To > determine if it's just firefox or mports. > Lastly; multimedia/x265 (a depends of multimedia/ffmpeg) a depends > of firefox. Is a *very* unhappy port; dumping 10's of thousands of > warnings for Bad Macro definitions. I mention it; as it may relate > to the firefox unhappiness. Well that sucks. Your MLM gratuitously stripped my attachments. :-( --Chris > > That's it. > > Thanks! :-) > > --Chris > > P.S. This might appear as a "double post". I used the wrong > From user name in the first posting. Sorry. :-( > _______________________________________________ > Midnightbsd-mports mailing list > Midnightbsd-mports at midnightbsd.org > https://www.midnightbsd.org/mailman/listinfo/midnightbsd-mports From midnightbsd at bsdforge.com Thu Sep 23 13:48:53 2021 From: midnightbsd at bsdforge.com (Chris) Date: Thu, 23 Sep 2021 10:48:53 -0700 Subject: [Midnightbsd-mports] www/firefox* diffs In-Reply-To: References: <4e0874b881c45aaa732c04b6c8733652@bsdforge.com> Message-ID: <8e78b2ca092929e7720008bfa61bdbb4@bsdforge.com> On 2021-09-23 10:37, Chris wrote: > On 2021-09-23 10:32, Chris wrote: >> Sorry I know the preferred method is via GitHub pull requests. >> But shortly after getting an account on GitHub a couple 3 years >> ago. I was unable to login. After some 30 days with tech support >> and no progress. I asked them to delete it. >> I don't have this problem with GitLab or Codeberg. >> >> Anyway. Please find attached 2 git(1) diff's; >> 1) www/firefox-esr (www-firefox-esr.diff >> 2) www/firefox (www-firefox.diff) >> In the case of firefox-esr, it's only "phase 1". I was able to >> eliminate all the errors emanating from the patches in files/. >> But as this is a fresh install on my laptop: >> ( MidnightBSD 2.1.0 #2 29cf808604(stable/2.1)-dirty: >> Mon Sep 20 18:25:51 EDT 2021 root at m2164: >> /usr/obj/usr/src/sys/GENERIC amd64 ) >> which isn't up to porting/development standards, This is as far >> as I can go till I can whip it into shape. I've been maintaining >> some 160 FreeBSD ports for around 7 years now. So this isn't >> unfamiliar territory. ;-) Tho there are some subtle differences. >> Which brings me to www/firefox. This one now builds and runs. But >> not w/o problems. So more investigation with firefox itself. To >> determine if it's just firefox or mports. >> Lastly; multimedia/x265 (a depends of multimedia/ffmpeg) a depends >> of firefox. Is a *very* unhappy port; dumping 10's of thousands of >> warnings for Bad Macro definitions. I mention it; as it may relate >> to the firefox unhappiness. > > Well that sucks. Your MLM gratuitously stripped my attachments. :-( Lets try it again. I had no problem supplying a patch for an Nvidia card back in 2015: (https://www.midnightbsd.org/pipermail/midnightbsd-mports/Week-of-Mon-20151221/000067.html) Maybe it's just the way I'm attaching them... > > --Chris >> >> That's it. >> >> Thanks! :-) >> >> --Chris >> >> P.S. This might appear as a "double post". I used the wrong >> From user name in the first posting. Sorry. :-( >> _______________________________________________ >> Midnightbsd-mports mailing list >> Midnightbsd-mports at midnightbsd.org >> https://www.midnightbsd.org/mailman/listinfo/midnightbsd-mports > _______________________________________________ > Midnightbsd-mports mailing list > Midnightbsd-mports at midnightbsd.org > https://www.midnightbsd.org/mailman/listinfo/midnightbsd-mports From midnightbsd at bsdforge.com Thu Sep 23 13:51:35 2021 From: midnightbsd at bsdforge.com (Chris) Date: Thu, 23 Sep 2021 10:51:35 -0700 Subject: [Midnightbsd-mports] www/firefox* diffs In-Reply-To: <8e78b2ca092929e7720008bfa61bdbb4@bsdforge.com> References: <4e0874b881c45aaa732c04b6c8733652@bsdforge.com> <8e78b2ca092929e7720008bfa61bdbb4@bsdforge.com> Message-ID: <4e27b75f27acebd484b99244a85d41bd@bsdforge.com> On 2021-09-23 10:48, Chris wrote: > On 2021-09-23 10:37, Chris wrote: >> On 2021-09-23 10:32, Chris wrote: >>> Sorry I know the preferred method is via GitHub pull requests. >>> But shortly after getting an account on GitHub a couple 3 years >>> ago. I was unable to login. After some 30 days with tech support >>> and no progress. I asked them to delete it. >>> I don't have this problem with GitLab or Codeberg. >>> >>> Anyway. Please find attached 2 git(1) diff's; >>> 1) www/firefox-esr (www-firefox-esr.diff >>> 2) www/firefox (www-firefox.diff) >>> In the case of firefox-esr, it's only "phase 1". I was able to >>> eliminate all the errors emanating from the patches in files/. >>> But as this is a fresh install on my laptop: >>> ( MidnightBSD 2.1.0 #2 29cf808604(stable/2.1)-dirty: >>> Mon Sep 20 18:25:51 EDT 2021 root at m2164: >>> /usr/obj/usr/src/sys/GENERIC amd64 ) >>> which isn't up to porting/development standards, This is as far >>> as I can go till I can whip it into shape. I've been maintaining >>> some 160 FreeBSD ports for around 7 years now. So this isn't >>> unfamiliar territory. ;-) Tho there are some subtle differences. >>> Which brings me to www/firefox. This one now builds and runs. But >>> not w/o problems. So more investigation with firefox itself. To >>> determine if it's just firefox or mports. >>> Lastly; multimedia/x265 (a depends of multimedia/ffmpeg) a depends >>> of firefox. Is a *very* unhappy port; dumping 10's of thousands of >>> warnings for Bad Macro definitions. I mention it; as it may relate >>> to the firefox unhappiness. >> >> Well that sucks. Your MLM gratuitously stripped my attachments. :-( > Lets try it again. I had no problem supplying a patch for an Nvidia > card back in 2015: > (https://www.midnightbsd.org/pipermail/midnightbsd-mports/Week-of-Mon-20151221/000067.html) > Maybe it's just the way I'm attaching them... Hmm... that didn't work. Lets try one at a time... www/firefox-esr >> >> --Chris >>> >>> That's it. >>> >>> Thanks! :-) >>> >>> --Chris >>> >>> P.S. This might appear as a "double post". I used the wrong >>> From user name in the first posting. Sorry. :-( From midnightbsd at bsdforge.com Thu Sep 23 14:00:23 2021 From: midnightbsd at bsdforge.com (Chris) Date: Thu, 23 Sep 2021 11:00:23 -0700 Subject: [Midnightbsd-mports] www/firefox* diffs In-Reply-To: <4e27b75f27acebd484b99244a85d41bd@bsdforge.com> References: <4e0874b881c45aaa732c04b6c8733652@bsdforge.com> <8e78b2ca092929e7720008bfa61bdbb4@bsdforge.com> <4e27b75f27acebd484b99244a85d41bd@bsdforge.com> Message-ID: On 2021-09-23 10:51, Chris wrote: > On 2021-09-23 10:48, Chris wrote: >> On 2021-09-23 10:37, Chris wrote: >>> On 2021-09-23 10:32, Chris wrote: >>>> Sorry I know the preferred method is via GitHub pull requests. >>>> But shortly after getting an account on GitHub a couple 3 years >>>> ago. I was unable to login. After some 30 days with tech support >>>> and no progress. I asked them to delete it. >>>> I don't have this problem with GitLab or Codeberg. >>>> >>>> Anyway. Please find attached 2 git(1) diff's; >>>> 1) www/firefox-esr (www-firefox-esr.diff >>>> 2) www/firefox (www-firefox.diff) >>>> In the case of firefox-esr, it's only "phase 1". I was able to >>>> eliminate all the errors emanating from the patches in files/. >>>> But as this is a fresh install on my laptop: >>>> ( MidnightBSD 2.1.0 #2 29cf808604(stable/2.1)-dirty: >>>> Mon Sep 20 18:25:51 EDT 2021 root at m2164: >>>> /usr/obj/usr/src/sys/GENERIC amd64 ) >>>> which isn't up to porting/development standards, This is as far >>>> as I can go till I can whip it into shape. I've been maintaining >>>> some 160 FreeBSD ports for around 7 years now. So this isn't >>>> unfamiliar territory. ;-) Tho there are some subtle differences. >>>> Which brings me to www/firefox. This one now builds and runs. But >>>> not w/o problems. So more investigation with firefox itself. To >>>> determine if it's just firefox or mports. >>>> Lastly; multimedia/x265 (a depends of multimedia/ffmpeg) a depends >>>> of firefox. Is a *very* unhappy port; dumping 10's of thousands of >>>> warnings for Bad Macro definitions. I mention it; as it may relate >>>> to the firefox unhappiness. >>> >>> Well that sucks. Your MLM gratuitously stripped my attachments. :-( >> Lets try it again. I had no problem supplying a patch for an Nvidia >> card back in 2015: >> (https://www.midnightbsd.org/pipermail/midnightbsd-mports/Week-of-Mon-20151221/000067.html) >> Maybe it's just the way I'm attaching them... > Hmm... that didn't work. Lets try one at a time... > www/firefox-esr OK this is *complete* nonsense. Why did I waste all this time trying to help others out? A complete WOT. :-( No wonder I'm the only one on the MidnightBSD mailing lists. Sincerely, disappointed. > >>> >>> --Chris >>>> >>>> That's it. >>>> >>>> Thanks! :-) >>>> >>>> --Chris >>>> >>>> P.S. This might appear as a "double post". I used the wrong >>>> From user name in the first posting. Sorry. :-( > _______________________________________________ > Midnightbsd-mports mailing list > Midnightbsd-mports at midnightbsd.org > https://www.midnightbsd.org/mailman/listinfo/midnightbsd-mports From chrish at ultimatedns.net Thu Sep 23 13:26:31 2021 From: chrish at ultimatedns.net (Chris Hutchinson) Date: Thu, 23 Sep 2021 10:26:31 -0700 Subject: [Midnightbsd-mports] www/firefox* git diffs Message-ID: Sorry I know the preferred method is via GitHub pull requests. But shortly after getting an account on GitHub a couple 3 years ago. I was unable to login. After some 30 days with tech support and no progress. I asked them to delete it. I don't have this problem with GitLab or Codeberg. Anyway. Please find attached 2 git(1) diff's; 1) www/firefox-esr (www-firefox-esr.diff 2) www/firefox (www-firefox.diff) In the case of firefox-esr, it's only "phase 1". I was able to eliminate all the errors emanating from the patches in files/. But as this is a fresh install on my laptop: ( MidnightBSD 2.1.0 #2 29cf808604(stable/2.1)-dirty: Mon Sep 20 18:25:51 EDT 2021 root at m2164: /usr/obj/usr/src/sys/GENERIC amd64 ) which isn't up to porting/development standards, This is as far as I can go till I can whip it into shape. I've been maintaining some 160 FreeBSD ports for around 7 years now. So this isn't unfamiliar territory. ;-) Tho there are some subtle differences. Which brings me to www/firefox. This one now builds and runs. But not w/o problems. So more investigation with firefox itself. To determine if it's just firefox or mports. Lastly; multimedia/x265 (a depends of multimedia/ffmpeg) a depends of firefox. Is a *very* unhappy port; dumping 10's of thousands of warnings for Bad Macro definitions. I mention it; as it may relate to the firefox unhappiness. That's it. Thanks! :-) --Chris From luke at foolishgames.com Thu Sep 23 16:11:17 2021 From: luke at foolishgames.com (Lucas Holt) Date: Thu, 23 Sep 2021 16:11:17 -0400 Subject: [Midnightbsd-mports] Submitting patches Message-ID: I think the issues were due to a filter on mime types that was added to our mailman install to stop certain types of spam.? I've added several mime types related to patches, which may solve the problem. Outside of mailing me directly and github, you should also be able to add patches to our jira instance. https://bugreport.midnightbsd.org/ Sorry about the inconvenience.? I did get one of the attempts in the admin queue and applied the firefox patches from Chris. Lucas From midnightbsd at bsdforge.com Thu Sep 23 16:44:02 2021 From: midnightbsd at bsdforge.com (Chris) Date: Thu, 23 Sep 2021 13:44:02 -0700 Subject: [Midnightbsd-mports] Submitting patches In-Reply-To: References: Message-ID: <079da68a582dc157b66ad76e864b7f72@bsdforge.com> On 2021-09-23 13:11, Lucas Holt wrote: > I think the issues were due to a filter on mime types that was added to our > mailman install to stop certain types of spam.? I've added several mime > types > related to patches, which may solve the problem. > > > Outside of mailing me directly and github, you should also be able to add > patches > to our jira instance. https://bugreport.midnightbsd.org/ Ah. Great. Thanks for the pointers! :-) > > > Sorry about the inconvenience.? I did get one of the attempts in the admin > queue > and applied the firefox patches from Chris. > > > Lucas > --Chris From midnightbsd at bsdforge.com Fri Sep 24 14:22:41 2021 From: midnightbsd at bsdforge.com (Chris) Date: Fri, 24 Sep 2021 11:22:41 -0700 Subject: [Midnightbsd-mports] DEVELOPER options appear to be broken/incomplete Message-ID: Well I ported a couple of additional ports -- ahem... Mports as well as 3 additional depends that one of them had to MidnightBSD. I would have submitted them yesterday. But went to install my favorite console editor: editors/vim. Only to find it was broken. So in an effort to expedite fixing it; I set DEVELOPER=true in make.conf(5). Which revealed that that /too/ was broken/incomplete -- /mports/Mk/Scripts/sed_checked.sh was missing. To expedite the matter I simply copied over the file from one of my FreeBSD boxes. I can't know if it's the right version of course. But it silenced the make error. :-/ Anyway. Thought I'd bring it up in case anyone might have some additional pointers/information. So I can clear up the anemic DEVELOPER option(s). Thanks! --Chris From luke at foolishgames.com Fri Sep 24 16:15:23 2021 From: luke at foolishgames.com (Lucas Holt) Date: Fri, 24 Sep 2021 16:15:23 -0400 Subject: [Midnightbsd-mports] DEVELOPER options appear to be broken/incomplete In-Reply-To: References: Message-ID: <85d92faa-de1b-77cf-6284-88012fc76599@foolishgames.com> On 9/24/21 2:22 PM, Chris wrote: > Well I ported a couple of additional ports -- ahem... Mports > as well as 3 additional depends that one of them had to > MidnightBSD. I would have submitted them yesterday. But went > to install my favorite console editor: editors/vim. Only to > find it was broken. So in an effort to expedite fixing it; I > set DEVELOPER=true in make.conf(5). Which revealed that that > /too/ was broken/incomplete -- /mports/Mk/Scripts/sed_checked.sh > was missing. To expedite the matter I simply copied over the > file from one of my FreeBSD boxes. I can't know if it's the > right version of course. But it silenced the make error. :-/ > Anyway. Thought I'd bring it up in case anyone might have > some additional pointers/information. So I can clear up the > anemic DEVELOPER option(s). Normally, we use MPORT_MAINTAINER_MODE=YES in /etc/make.conf to enable developer related settings.? There are some things that were brought in over time from FreeBSD ports with respect to the DEVELOPER option and it might be nice to get those working all the way. The primary benefit of MPORT_MAINTAINER_MODE is that it enables additional checks for plists. it will tell you if things are installed outside of the fake directory in many cases, and also if things are missing. fake is pretty similar to FreeBSD stage except that it predates it and there are a few differences in behavior. Most notably the do-install, post-install targets get DESTDIR prepended to PREFIX but the newer options specific ones do not. You can get the real prefix with TRUE_PREFIX and STAGEDIR becomes FAKE_DESTDIR. The only other difference is an annoying OPTIONS bug I haven't tracked down where it can prompt you for make config over and over.? I suspect it's either included at the wrong time or that it's not saving the options file properly due to a path issue. This is mostly noticeable on python ports that use options.